public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Cygwin: __wscollate_range_cmp: fix incorrect comment
@ 2023-02-28 15:46 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-02-28 15:46 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6e75277b122c47ca63d9520780291cf4bc7251cf
commit 6e75277b122c47ca63d9520780291cf4bc7251cf
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Tue Feb 28 12:10:40 2023 +0100
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Feb 28 12:24:29 2023 +0100
Cygwin: __wscollate_range_cmp: fix incorrect comment
The comment that the first arg must be the pattern was added
during development, before it turned out that __wscollate_range_cmp
can be implemented in an order independent way.
Better explain why this function uses pointers to strings.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/nlsfuncs.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/nlsfuncs.cc b/winsup/cygwin/nlsfuncs.cc
index dd0fc8dc5f4f..04d7072e7987 100644
--- a/winsup/cygwin/nlsfuncs.cc
+++ b/winsup/cygwin/nlsfuncs.cc
@@ -1212,8 +1212,8 @@ __wcollate_range_cmp (wint_t c1, wint_t c2)
/* Not so much BSD. Used from glob.cc, fnmatch.c and regcomp.c.
- First arg is always from pattern space, second arg is the tested string.
- len is the length of the pattern in the first arg. */
+ The args are pointers to wint_t strings. This allows to compare
+ against collating symbols. */
extern "C" int
__wscollate_range_cmp (wint_t *c1, wint_t *c2,
size_t c1len, size_t c2len)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-28 15:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 15:46 [newlib-cygwin/main] Cygwin: __wscollate_range_cmp: fix incorrect comment Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).