public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: thread: Reset _my_tls.tid if it's pthread_null in init_mainthread().
@ 2023-07-03 11:03 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2023-07-03 11:03 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=bfb16b0edef49b8e694bcb1b419bfcb5a0a3dfac

commit bfb16b0edef49b8e694bcb1b419bfcb5a0a3dfac
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Fri Jun 23 00:07:26 2023 +0900

    Cygwin: thread: Reset _my_tls.tid if it's pthread_null in init_mainthread().
    
    Currently, _my_tls.tid is set to pthread_null if pthread::self()
    is called before pthread::init_mainthread(). As a result, pthread::
    init_mainthread() does not set _my_tls.tid appropriately. Due to
    this, pthread_join() fails in LDAP environment if the program is
    the first program which loads cygwin1.dll.
    
    https://cygwin.com/pipermail/cygwin/2023-June/253792.html
    
    With this patch, _my_tls.tid is re-initialized in pthread::
    init_mainthread() if it is pthread_null.
    
    Reported-by: Mümin A. <muminaydin06@gmail.com>
    Reviewed-by: Corinna Vinschen <corinna@vinschen.de>
    Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>

Diff:
---
 winsup/cygwin/thread.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
index 5c1284a93..f614e01c4 100644
--- a/winsup/cygwin/thread.cc
+++ b/winsup/cygwin/thread.cc
@@ -364,7 +364,7 @@ void
 pthread::init_mainthread ()
 {
   pthread *thread = _my_tls.tid;
-  if (!thread)
+  if (!thread || thread == pthread_null::get_null_pthread ())
     {
       thread = new pthread ();
       if (!thread)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-03 11:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 11:03 [newlib-cygwin] Cygwin: thread: Reset _my_tls.tid if it's pthread_null in init_mainthread() Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).