public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: testsuite: Just log result of second open of /dev/dsp
@ 2023-07-09 16:01 Jon Turney
0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2023-07-09 16:01 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=062e62638c71c228fe56aa1228d8bbfeaa8ec140
commit 062e62638c71c228fe56aa1228d8bbfeaa8ec140
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Fri Jul 7 13:36:29 2023 +0100
Cygwin: testsuite: Just log result of second open of /dev/dsp
Do not rate successful second open of /dev/dsp as an error, just log the
result.
Based on this patch by Gerd Spalink:
https://cygwin.com/pipermail/cygwin-patches/2004q3/004848.html
Also, disable forkplaytest() which is broken in some complex way I don't
understand.
Diff:
---
winsup/testsuite/winsup.api/devdsp.c | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/winsup/testsuite/winsup.api/devdsp.c b/winsup/testsuite/winsup.api/devdsp.c
index 0ac76f085..b63a269d6 100644
--- a/winsup/testsuite/winsup.api/devdsp.c
+++ b/winsup/testsuite/winsup.api/devdsp.c
@@ -85,7 +85,7 @@ main (int argc, char *argv[])
playbacktest ();
recordingtest ();
monitortest ();
- forkplaytest ();
+ // forkplaytest (); // broken somehow, second child process hangs on exit?
forkrectest ();
abortplaytest ();
playwavtest ();
@@ -170,15 +170,11 @@ playbacktest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_WRONLY);
+ tst_resm (TINFO, "Second open /dev/dsp W %s ",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp W succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
@@ -209,15 +205,11 @@ recordingtest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_RDONLY);
+ tst_resm (TINFO, "Second open /dev/dsp R %s",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp R succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [newlib-cygwin] Cygwin: testsuite: Just log result of second open of /dev/dsp
@ 2023-07-14 15:28 Jon Turney
0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2023-07-14 15:28 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=7c0750e96294c4c565fadc662219d56f93af389d
commit 7c0750e96294c4c565fadc662219d56f93af389d
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Fri Jul 7 13:36:29 2023 +0100
Cygwin: testsuite: Just log result of second open of /dev/dsp
Do not rate successful second open of /dev/dsp as an error, just log the
result.
Based on this patch by Gerd Spalink:
https://cygwin.com/pipermail/cygwin-patches/2004q3/004848.html
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
Diff:
---
winsup/testsuite/winsup.api/devdsp.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/winsup/testsuite/winsup.api/devdsp.c b/winsup/testsuite/winsup.api/devdsp.c
index 0ac76f085..de3ccfa19 100644
--- a/winsup/testsuite/winsup.api/devdsp.c
+++ b/winsup/testsuite/winsup.api/devdsp.c
@@ -170,15 +170,11 @@ playbacktest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_WRONLY);
+ tst_resm (TINFO, "Second open /dev/dsp W %s ",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp W succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
@@ -209,15 +205,11 @@ recordingtest (void)
strerror (errno));
}
audio2 = open ("/dev/dsp", O_RDONLY);
+ tst_resm (TINFO, "Second open /dev/dsp R %s",
+ audio2 >= 0 ? "WORKS" : "DOESN'T WORK");
if (audio2 >= 0)
{
- tst_brkm (TFAIL, cleanup,
- "Second open /dev/dsp R succeeded, but is expected to fail");
- }
- else if (errno != EBUSY)
- {
- tst_brkm (TFAIL, cleanup, "Expected EBUSY here, exit: %s",
- strerror (errno));
+ close (audio2);
}
for (rate = 0; rate < sizeof (rates) / sizeof (int); rate++)
for (k = 0; k < sizeof (sblut) / sizeof (struct sb); k++)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-14 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09 16:01 [newlib-cygwin] Cygwin: testsuite: Just log result of second open of /dev/dsp Jon Turney
2023-07-14 15:28 Jon Turney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).