public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: readdir: explain why we use FileNamesInformation on NFS
Date: Sat,  9 Sep 2023 21:29:16 +0000 (GMT)	[thread overview]
Message-ID: <20230909212916.8A1D33858C74@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5302638f77398978cd5403e00925d8f482442c84

commit 5302638f77398978cd5403e00925d8f482442c84
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Sat Sep 9 23:05:29 2023 +0200
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Sat Sep 9 23:28:55 2023 +0200

    Cygwin: readdir: explain why we use FileNamesInformation on NFS
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler/disk_file.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/cygwin/fhandler/disk_file.cc b/winsup/cygwin/fhandler/disk_file.cc
index 4f373637e514..0242cae2fd43 100644
--- a/winsup/cygwin/fhandler/disk_file.cc
+++ b/winsup/cygwin/fhandler/disk_file.cc
@@ -2262,6 +2262,8 @@ fhandler_disk_file::readdir (DIR *dir, dirent *de)
 	      goto go_ahead;
 	    }
 	}
+      /* NFS must use FileNamesInformation!  Any other information class
+	 skips all symlinks. */
       if (!(dir->__flags & dirent_get_d_ino))
 	status = NtQueryDirectoryFile (get_handle (), NULL, NULL, NULL, &io,
 				       d_cache (dir), DIR_BUF_SIZE,

                 reply	other threads:[~2023-09-09 21:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230909212916.8A1D33858C74@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).