public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Cygwin: readdir: explain why we use FileNamesInformation on NFS
@ 2023-09-09 21:29 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-09-09 21:29 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5302638f77398978cd5403e00925d8f482442c84

commit 5302638f77398978cd5403e00925d8f482442c84
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Sat Sep 9 23:05:29 2023 +0200
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Sat Sep 9 23:28:55 2023 +0200

    Cygwin: readdir: explain why we use FileNamesInformation on NFS
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler/disk_file.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/cygwin/fhandler/disk_file.cc b/winsup/cygwin/fhandler/disk_file.cc
index 4f373637e514..0242cae2fd43 100644
--- a/winsup/cygwin/fhandler/disk_file.cc
+++ b/winsup/cygwin/fhandler/disk_file.cc
@@ -2262,6 +2262,8 @@ fhandler_disk_file::readdir (DIR *dir, dirent *de)
 	      goto go_ahead;
 	    }
 	}
+      /* NFS must use FileNamesInformation!  Any other information class
+	 skips all symlinks. */
       if (!(dir->__flags & dirent_get_d_ino))
 	status = NtQueryDirectoryFile (get_handle (), NULL, NULL, NULL, &io,
 				       d_cache (dir), DIR_BUF_SIZE,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-09 21:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-09 21:29 [newlib-cygwin/main] Cygwin: readdir: explain why we use FileNamesInformation on NFS Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).