public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Cygwin: dsp: Avoid setting buffer that is too small.
@ 2023-09-17 13:40 Takashi Yano
  0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2023-09-17 13:40 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=322c7150b25ebd2c4c2bd4e3abbe0978f66f3737

commit 322c7150b25ebd2c4c2bd4e3abbe0978f66f3737
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Sun Sep 17 08:49:34 2023 +0900

    Cygwin: dsp: Avoid setting buffer that is too small.
    
    The buffer size that is too small causes choppy sound. That is not
    practical at all. With this patch, the minimum value of the buffer
    size (i.e. fragstotal * fragsize) is restricted to 16384 bytes.
    
    Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>

Diff:
---
 winsup/cygwin/fhandler/dsp.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/cygwin/fhandler/dsp.cc b/winsup/cygwin/fhandler/dsp.cc
index 03c812a9c..97f3eaa27 100644
--- a/winsup/cygwin/fhandler/dsp.cc
+++ b/winsup/cygwin/fhandler/dsp.cc
@@ -1430,6 +1430,8 @@ fhandler_dev_dsp::_ioctl (unsigned int cmd, void *buf)
 	int *p = (int *) buf;
 	fragstotal_ = min (*p >> 16, MAX_BLOCKS);
 	fragsize_ = 1 << (*p & 0xffff);
+	while (fragsize_ * fragstotal_ < 16384)
+	  fragsize_ *= 2;
 	fragment_has_been_set = true;
 	return 0;
       }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-17 13:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-17 13:40 [newlib-cygwin] Cygwin: dsp: Avoid setting buffer that is too small Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).