public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: fallocate(2): drop useless zeroing pointer
Date: Mon,  4 Dec 2023 09:21:51 +0000 (GMT)	[thread overview]
Message-ID: <20231204092151.C748E385AC09@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c0d2f3874207e870ffb8a181b0a49637d77e5fdc

commit c0d2f3874207e870ffb8a181b0a49637d77e5fdc
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Sat Dec 2 14:38:28 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Mon Dec 4 10:20:55 2023 +0100

    Cygwin: fallocate(2): drop useless zeroing pointer
    
    The out pointer is only used if data_chunk_count is > 0,
    so there's no reason to set it to NULL in the error case.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler/disk_file.cc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/winsup/cygwin/fhandler/disk_file.cc b/winsup/cygwin/fhandler/disk_file.cc
index ce15e41a4e77..d08fe9160d35 100644
--- a/winsup/cygwin/fhandler/disk_file.cc
+++ b/winsup/cygwin/fhandler/disk_file.cc
@@ -1319,9 +1319,7 @@ fhandler_disk_file::falloc_zero_range (int mode, off_t offset, off_t length)
       status = NtFsControlFile (get_handle (), NULL, NULL, NULL,
 				&io, FSCTL_QUERY_ALLOCATED_RANGES,
 				&inp, sizeof inp, out, 2 * NT_MAX_PATH);
-      if (NT_ERROR (status))
-	out = NULL;
-      else
+      if (!NT_ERROR (status))
 	data_chunk_count = io.Information / sizeof *out;
     }

                 reply	other threads:[~2023-12-04  9:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231204092151.C748E385AC09@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).