public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Cygwin: fallocate(2): drop useless zeroing pointer
@ 2023-12-04 9:21 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-12-04 9:21 UTC (permalink / raw)
To: cygwin-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c0d2f3874207e870ffb8a181b0a49637d77e5fdc
commit c0d2f3874207e870ffb8a181b0a49637d77e5fdc
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Sat Dec 2 14:38:28 2023 +0100
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Mon Dec 4 10:20:55 2023 +0100
Cygwin: fallocate(2): drop useless zeroing pointer
The out pointer is only used if data_chunk_count is > 0,
so there's no reason to set it to NULL in the error case.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/fhandler/disk_file.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/winsup/cygwin/fhandler/disk_file.cc b/winsup/cygwin/fhandler/disk_file.cc
index ce15e41a4e77..d08fe9160d35 100644
--- a/winsup/cygwin/fhandler/disk_file.cc
+++ b/winsup/cygwin/fhandler/disk_file.cc
@@ -1319,9 +1319,7 @@ fhandler_disk_file::falloc_zero_range (int mode, off_t offset, off_t length)
status = NtFsControlFile (get_handle (), NULL, NULL, NULL,
&io, FSCTL_QUERY_ALLOCATED_RANGES,
&inp, sizeof inp, out, 2 * NT_MAX_PATH);
- if (NT_ERROR (status))
- out = NULL;
- else
+ if (!NT_ERROR (status))
data_chunk_count = io.Information / sizeof *out;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-04 9:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04 9:21 [newlib-cygwin/main] Cygwin: fallocate(2): drop useless zeroing pointer Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).