public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: [PATCH v8 0/1] Pseudo console support in PTY (v8)
Date: Thu, 29 Aug 2019 11:58:00 -0000	[thread overview]
Message-ID: <20190829115836.GY11632@calimero.vinschen.de> (raw)
In-Reply-To: <20190829080508.GV11632@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Aug 29 10:05, Corinna Vinschen wrote:
> On Aug 29 08:48, Thomas Wolff wrote:
> > Hi Takashi,
> > 
> > Am 27.08.2019 um 20:06 schrieb Takashi Yano:
> > > Hi Thomas,
> > > 
> > > On Sun, 25 Aug 2019 00:22:29 +0200
> > > Thomas Wolff wrote:
> > > > > I tested using your STC in mintty start by 'mintty -o Charset=CP1252'.
> > > > > It seems to work as expected.
> > > > Option Charset needs an additional option Locale to have an effect.
> > > > The easier way is
> > > > LC_ALL=de_DE mintty
> > > > or
> > > > LC_ALL=ja_JP mintty
> > > I have posted v9 patch. Hopefully, this works now.
> > > Could you please test?
> > Quickly restesting the character conversion in non-UTF-8 terminal, this
> > works fine, thank you.
> > Not retested the whole test suite yet...
> > But I'd say the patch is fine now for a test release.
> > Thomas
> 
> Thanks for testing, I'll push the patch and create a test release
> as soon as I find time.
> 
> Takashi, any idea for a one sentence release text?

Never mind, your commit message is just fine for the job.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2019-08-29 11:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 15:43 Takashi Yano
2019-08-21 15:43 ` [PATCH v8 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-08-27  8:24   ` Corinna Vinschen
2019-08-27  8:39     ` Thomas Wolff
2019-08-27  8:47       ` Corinna Vinschen
2019-08-27 15:52         ` Takashi Yano
2019-08-27 15:58           ` Corinna Vinschen
2019-08-23 22:30 ` [PATCH v8 0/1] Pseudo console support in PTY (v8) Thomas Wolff
2019-08-24  6:18   ` Takashi Yano
2019-08-24 22:22     ` Thomas Wolff
2019-08-27 18:06       ` Takashi Yano
2019-08-29  6:49         ` Thomas Wolff
2019-08-29  8:05           ` Corinna Vinschen
2019-08-29 11:58             ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829115836.GY11632@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-developers@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).