From: Thomas Wolff <towo@towo.net>
To: cygwin-developers@cygwin.com
Subject: Re: [PATCH v8 0/1] Pseudo console support in PTY (v8)
Date: Fri, 23 Aug 2019 22:30:00 -0000 [thread overview]
Message-ID: <eed9a813-062b-b1d3-032d-e4a09f891df8@towo.net> (raw)
In-Reply-To: <20190821154239.9197-1-takashi.yano@nifty.ne.jp>
Am 21.08.2019 um 17:42 schrieb Takashi Yano:
> Changes from v7:
> Make the programs work which call WIN32 APIs such as WriteConsole()
> directly despite being linked with cygwin1.dll. This is realized
> by hooking some WIN32 APIs and switching I/O to the pseudo console
> if console access is detected.
>
> ...
I've retested my cases, and also checked WriteConsole and WriteFile
cases. These work fine now, amazing!
Character set conversion for non-cygwin programs in a non-UTF-8 terminal
still does not work for me. But that is a minor issue, at least it's not
worse than before.
Switching to the alternate screen buffer and back via escape sequence is
now completely disabled while running a non-cygwin program like cmd.exe.
This is effectively fine, I just wonder how much effort you put into
handling that (it seemed to work well already in v7 when switching was
still possible); you can still force-switch from the mintty extended
context menu and see it forced back on further interaction...
After all, I'm looking forward to the integration of your patch in
cygwin, so I can close long-standing mintty issue #56 :)
Many thanks
Thomas
next prev parent reply other threads:[~2019-08-23 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:43 Takashi Yano
2019-08-21 15:43 ` [PATCH v8 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-08-27 8:24 ` Corinna Vinschen
2019-08-27 8:39 ` Thomas Wolff
2019-08-27 8:47 ` Corinna Vinschen
2019-08-27 15:52 ` Takashi Yano
2019-08-27 15:58 ` Corinna Vinschen
2019-08-23 22:30 ` Thomas Wolff [this message]
2019-08-24 6:18 ` [PATCH v8 0/1] Pseudo console support in PTY (v8) Takashi Yano
2019-08-24 22:22 ` Thomas Wolff
2019-08-27 18:06 ` Takashi Yano
2019-08-29 6:49 ` Thomas Wolff
2019-08-29 8:05 ` Corinna Vinschen
2019-08-29 11:58 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed9a813-062b-b1d3-032d-e4a09f891df8@towo.net \
--to=towo@towo.net \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).