From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-developers@cygwin.com
Subject: Re: Performance regression in cygwin 3.4.0
Date: Fri, 9 Dec 2022 09:48:14 +0900 [thread overview]
Message-ID: <20221209094814.a1b4e632fa16d71e673506ed@nifty.ne.jp> (raw)
In-Reply-To: <8bf2dfae-1041-0bb7-9dc7-d255747bebfe@cornell.edu>
On Thu, 8 Dec 2022 15:56:43 -0500
Ken Brown wrote:
> On 12/8/2022 10:30 AM, Corinna Vinschen wrote:
> > Hi Takashi,
> > As for the code, I have just one nit. Don't use GetTickCount. Use
> > GetTickCount64(). I just noticed you're using it in tty::wait_fwd as
> > well. Please use GetTickCount64() there, too. This way you can
> > get rid of the overflow handling.
> >
> > Ken? Any more input?
>
> LGTM.
Thanks for reviewing. I will submit a revised patch
to cygwin-patches@cygwin.com.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
prev parent reply other threads:[~2022-12-09 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Abw9_BgkZRll8zEaAWSNVO1Uw0sF_--Amd02G5fpj3r5O6QBhyqjWu2cxV1IctJtM03OGztfZx60TEIYfDi34p3_unluAxKgQDzcsYZASxY=@proton.me>
[not found] ` <20221208184656.ea6b9796eccc503c1e238f0f@nifty.ne.jp>
2022-12-08 14:54 ` Takashi Yano
2022-12-08 15:30 ` Corinna Vinschen
2022-12-08 20:56 ` Ken Brown
2022-12-09 0:48 ` Takashi Yano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209094814.a1b4e632fa16d71e673506ed@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).