public inbox for
 help / color / mirror / Atom feed
* [PATCH] Cygwin: fix mknod (64-bit only)
@ 2022-05-22 16:18 Ken Brown
  0 siblings, 0 replies; only message in thread
From: Ken Brown @ 2022-05-22 16:18 UTC (permalink / raw)
  To: cygwin-patches

[-- Attachment #1: Type: text/plain, Size: 87 bytes --]

Patch attached.  I'll push it in a few days if no one sees anything wrong with it.


[-- Attachment #2: 0001-Cygwin-fix-mknod-64-bit-only.patch --]
[-- Type: text/plain, Size: 1733 bytes --]

From 54cfc70ff3a548d861cb59ac6b2084cc6b791ec2 Mon Sep 17 00:00:00 2001
From: Ken Brown <>
Date: Sun, 22 May 2022 11:43:44 -0400
Subject: [PATCH] Cygwin: fix mknod (64-bit only)

The current definition of mknod in has a third argument of
type __dev16_t instead of dev_t.  Fix this on 64-bit Cygwin by
exporting mknod as an alias for mknod32.  (There is no problem on
32-bit because mknod is redirected to mknod32 via NEW_FUNCTIONS in

 winsup/cygwin/release/3.3.6 | 3 +++
 winsup/cygwin/   | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/winsup/cygwin/release/3.3.6 b/winsup/cygwin/release/3.3.6
index 6d722433f..135f33155 100644
--- a/winsup/cygwin/release/3.3.6
+++ b/winsup/cygwin/release/3.3.6
@@ -7,3 +7,6 @@ Bug Fixes
 - Fix killpg failing because the exec'ing as well as the exec'ed
   process are not in the pidlist for a brief moment.
+- Fix mknod (64-bit only), whose definition didn't match its prototype.
+  Addresses:
diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 3a652c4f4..344d1d329 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -3490,11 +3490,15 @@ mknod32 (const char *path, mode_t mode, dev_t dev)
   return -1;
+#ifdef __i386__
 extern "C" int
 mknod (const char *_path, mode_t mode, __dev16_t dev)
   return mknod32 (_path, mode, (dev_t) dev);
+EXPORT_ALIAS (mknod32, mknod)
 extern "C" int
 mkfifo (const char *path, mode_t mode)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-22 16:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 16:18 [PATCH] Cygwin: fix mknod (64-bit only) Ken Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).