public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* [PATCH] Cygwin: pty: Fix a bug on redirecting something to /dev/pty*.
@ 2020-07-18  4:48 Takashi Yano
  2020-07-20  8:07 ` Corinna Vinschen
  0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2020-07-18  4:48 UTC (permalink / raw)
  To: cygwin-patches

- After commit 0365031ce1347600d854a23f30f1355745a1765c, key input
  becomes not working by following steps.
   1) Start cmd.exe in mintty.
   2) Open another mintty.
   3) Execute "echo AAA > /dev/pty*" (pty* is the pty opened in 1.)
  This patch fixes the issue.
---
 winsup/cygwin/fhandler_tty.cc | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index a61167116..6a004f3a5 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -969,11 +969,6 @@ fhandler_pty_slave::open (int flags, mode_t)
       init_console_handler (true);
     }
 
-  isHybrid = false;
-  get_ttyp ()->pcon_pid = 0;
-  get_ttyp ()->switch_to_pcon_in = false;
-  get_ttyp ()->switch_to_pcon_out = false;
-
   set_open_status ();
   return 1;
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Cygwin: pty: Fix a bug on redirecting something to /dev/pty*.
  2020-07-18  4:48 [PATCH] Cygwin: pty: Fix a bug on redirecting something to /dev/pty* Takashi Yano
@ 2020-07-20  8:07 ` Corinna Vinschen
  0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-07-20  8:07 UTC (permalink / raw)
  To: cygwin-patches

On Jul 18 13:48, Takashi Yano via Cygwin-patches wrote:
> - After commit 0365031ce1347600d854a23f30f1355745a1765c, key input
>   becomes not working by following steps.
>    1) Start cmd.exe in mintty.
>    2) Open another mintty.
>    3) Execute "echo AAA > /dev/pty*" (pty* is the pty opened in 1.)
>   This patch fixes the issue.
> ---
>  winsup/cygwin/fhandler_tty.cc | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index a61167116..6a004f3a5 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -969,11 +969,6 @@ fhandler_pty_slave::open (int flags, mode_t)
>        init_console_handler (true);
>      }
>  
> -  isHybrid = false;
> -  get_ttyp ()->pcon_pid = 0;
> -  get_ttyp ()->switch_to_pcon_in = false;
> -  get_ttyp ()->switch_to_pcon_out = false;
> -
>    set_open_status ();
>    return 1;
>  
> -- 
> 2.27.0

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-20  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18  4:48 [PATCH] Cygwin: pty: Fix a bug on redirecting something to /dev/pty* Takashi Yano
2020-07-20  8:07 ` Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).