* [PATCH] fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcode
@ 2020-08-04 6:51 Brian Inglis
2020-08-04 8:12 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Brian Inglis @ 2020-08-04 6:51 UTC (permalink / raw)
To: Cygwin Patches
microcode is unsigned long long, printed by _small_sprintf using %x;
Cygwin32 used last 4 bytes of microcode for next field MHz, printing 0;
use correct _small_sprintf format %X to print microcode, producing
correct MHz value under Cygwin32
---
winsup/cygwin/fhandler_proc.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
index 72ffa89cdc79..9a20c23d4b65 100644
--- a/winsup/cygwin/fhandler_proc.cc
+++ b/winsup/cygwin/fhandler_proc.cc
@@ -833,7 +833,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
"model\t\t: %d\n"
"model name\t: %s\n"
"stepping\t: %d\n"
- "microcode\t: 0x%x\n"
+ "microcode\t: 0x%X\n"
"cpu MHz\t\t: %d.000\n",
family,
model,
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcode
2020-08-04 6:51 [PATCH] fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcode Brian Inglis
@ 2020-08-04 8:12 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-08-04 8:12 UTC (permalink / raw)
To: cygwin-patches
On Aug 4 00:51, Brian Inglis wrote:
> microcode is unsigned long long, printed by _small_sprintf using %x;
> Cygwin32 used last 4 bytes of microcode for next field MHz, printing 0;
> use correct _small_sprintf format %X to print microcode, producing
> correct MHz value under Cygwin32
> ---
> winsup/cygwin/fhandler_proc.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
> index 72ffa89cdc79..9a20c23d4b65 100644
> --- a/winsup/cygwin/fhandler_proc.cc
> +++ b/winsup/cygwin/fhandler_proc.cc
> @@ -833,7 +833,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
> "model\t\t: %d\n"
> "model name\t: %s\n"
> "stepping\t: %d\n"
> - "microcode\t: 0x%x\n"
> + "microcode\t: 0x%X\n"
> "cpu MHz\t\t: %d.000\n",
> family,
> model,
> --
> 2.28.0
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-04 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 6:51 [PATCH] fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcode Brian Inglis
2020-08-04 8:12 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).