public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* [PATCH] Cygwin: cwdstuff::get: clean up debug_printf output
@ 2020-08-23 22:51 Ken Brown
  2020-08-24  9:07 ` Corinna Vinschen
  0 siblings, 1 reply; 2+ messages in thread
From: Ken Brown @ 2020-08-23 22:51 UTC (permalink / raw)
  To: cygwin-patches

Set errno = 0 at the beginning so that the debug_printf call at the
end doesn't report a nonzero errno left over from some other function
call.
---
 winsup/cygwin/path.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index f3b9913bd..95faf8ca7 100644
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -5022,6 +5022,8 @@ char *
 cwdstuff::get (char *buf, int need_posix, int with_chroot, unsigned ulen)
 {
   tmp_pathbuf tp;
+
+  errno = 0;
   if (ulen)
     /* nothing */;
   else if (buf == NULL)
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Cygwin: cwdstuff::get: clean up debug_printf output
  2020-08-23 22:51 [PATCH] Cygwin: cwdstuff::get: clean up debug_printf output Ken Brown
@ 2020-08-24  9:07 ` Corinna Vinschen
  0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-08-24  9:07 UTC (permalink / raw)
  To: cygwin-patches

On Aug 23 18:51, Ken Brown via Cygwin-patches wrote:
> Set errno = 0 at the beginning so that the debug_printf call at the
> end doesn't report a nonzero errno left over from some other function
> call.
> ---
>  winsup/cygwin/path.cc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index f3b9913bd..95faf8ca7 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -5022,6 +5022,8 @@ char *
>  cwdstuff::get (char *buf, int need_posix, int with_chroot, unsigned ulen)
>  {
>    tmp_pathbuf tp;
> +
> +  errno = 0;
>    if (ulen)
>      /* nothing */;
>    else if (buf == NULL)
> -- 
> 2.28.0

Please push.


Thanks,
Corinna

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-24  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-23 22:51 [PATCH] Cygwin: cwdstuff::get: clean up debug_printf output Ken Brown
2020-08-24  9:07 ` Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).