From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pty: Revise the workaround for rlwrap.
Date: Wed, 16 Dec 2020 10:40:00 +0100 [thread overview]
Message-ID: <20201216094000.GG4560@calimero.vinschen.de> (raw)
In-Reply-To: <20201216091058.1938-1-takashi.yano@nifty.ne.jp>
On Dec 16 18:10, Takashi Yano via Cygwin-patches wrote:
> - Previous workaround has a problem that screen is distorted if up
> arrow key is pressed at the first line after running "rlwrap cmd".
> This patch fixes the issue.
> ---
> winsup/cygwin/fhandler_tty.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 77d9d9b47..77f7bfe43 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -1111,8 +1111,8 @@ fhandler_pty_slave::tcgetattr (struct termios *t)
> *t = get_ttyp ()->ti;
> /* Workaround for rlwrap */
> if (get_ttyp ()->pcon_start)
> - t->c_lflag &= ~ICANON;
> - else if (get_ttyp ()->h_pseudo_console)
> + t->c_lflag &= ~(ICANON | ECHO);
> + if (get_ttyp ()->h_pseudo_console)
> t->c_iflag &= ~ICRNL;
> return 0;
> }
> --
> 2.29.2
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2020-12-16 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 9:10 Takashi Yano
2020-12-16 9:40 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216094000.GG4560@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).