* [PATCH] Cygwin: pty: Revise the workaround for rlwrap.
@ 2020-12-16 9:10 Takashi Yano
2020-12-16 9:40 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2020-12-16 9:10 UTC (permalink / raw)
To: cygwin-patches
- Previous workaround has a problem that screen is distorted if up
arrow key is pressed at the first line after running "rlwrap cmd".
This patch fixes the issue.
---
winsup/cygwin/fhandler_tty.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 77d9d9b47..77f7bfe43 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1111,8 +1111,8 @@ fhandler_pty_slave::tcgetattr (struct termios *t)
*t = get_ttyp ()->ti;
/* Workaround for rlwrap */
if (get_ttyp ()->pcon_start)
- t->c_lflag &= ~ICANON;
- else if (get_ttyp ()->h_pseudo_console)
+ t->c_lflag &= ~(ICANON | ECHO);
+ if (get_ttyp ()->h_pseudo_console)
t->c_iflag &= ~ICRNL;
return 0;
}
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Cygwin: pty: Revise the workaround for rlwrap.
2020-12-16 9:10 [PATCH] Cygwin: pty: Revise the workaround for rlwrap Takashi Yano
@ 2020-12-16 9:40 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-12-16 9:40 UTC (permalink / raw)
To: cygwin-patches
On Dec 16 18:10, Takashi Yano via Cygwin-patches wrote:
> - Previous workaround has a problem that screen is distorted if up
> arrow key is pressed at the first line after running "rlwrap cmd".
> This patch fixes the issue.
> ---
> winsup/cygwin/fhandler_tty.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 77d9d9b47..77f7bfe43 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -1111,8 +1111,8 @@ fhandler_pty_slave::tcgetattr (struct termios *t)
> *t = get_ttyp ()->ti;
> /* Workaround for rlwrap */
> if (get_ttyp ()->pcon_start)
> - t->c_lflag &= ~ICANON;
> - else if (get_ttyp ()->h_pseudo_console)
> + t->c_lflag &= ~(ICANON | ECHO);
> + if (get_ttyp ()->h_pseudo_console)
> t->c_iflag &= ~ICRNL;
> return 0;
> }
> --
> 2.29.2
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-16 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 9:10 [PATCH] Cygwin: pty: Revise the workaround for rlwrap Takashi Yano
2020-12-16 9:40 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).