* [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe.
@ 2021-01-15 9:26 Takashi Yano
2021-01-18 15:00 ` Takashi Yano
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Yano @ 2021-01-15 9:26 UTC (permalink / raw)
To: cygwin-patches
- cat exits immediately in the following senario.
1) Execute env CYGWIN=disable_pcon script
2) Execute cmd.exe
3) Execute cat in cmd.exe.
This is caused by setting input_available_event for the pipe for
non-cygwin app. This patch fixes the issue.
---
winsup/cygwin/fhandler_tty.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index e4993bf31..0b9901974 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -394,7 +394,8 @@ fhandler_pty_master::accept_input ()
}
}
- SetEvent (input_available_event);
+ if (write_to == get_output_handle ())
+ SetEvent (input_available_event);
ReleaseMutex (input_mutex);
return ret;
}
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe.
2021-01-15 9:26 [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe Takashi Yano
@ 2021-01-18 15:00 ` Takashi Yano
2021-01-18 15:27 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Yano @ 2021-01-18 15:00 UTC (permalink / raw)
To: cygwin-patches
Hi Corinna,
On Fri, 15 Jan 2021 18:26:31 +0900
Takashi Yano wrote:
> - cat exits immediately in the following senario.
> 1) Execute env CYGWIN=disable_pcon script
> 2) Execute cmd.exe
> 3) Execute cat in cmd.exe.
> This is caused by setting input_available_event for the pipe for
> non-cygwin app. This patch fixes the issue.
> ---
> winsup/cygwin/fhandler_tty.cc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index e4993bf31..0b9901974 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -394,7 +394,8 @@ fhandler_pty_master::accept_input ()
> }
> }
>
> - SetEvent (input_available_event);
> + if (write_to == get_output_handle ())
> + SetEvent (input_available_event);
> ReleaseMutex (input_mutex);
> return ret;
> }
> --
> 2.30.0
>
I would be happy if you could review this patch as well.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe.
2021-01-18 15:00 ` Takashi Yano
@ 2021-01-18 15:27 ` Corinna Vinschen
2021-01-18 15:41 ` Takashi Yano
0 siblings, 1 reply; 4+ messages in thread
From: Corinna Vinschen @ 2021-01-18 15:27 UTC (permalink / raw)
To: cygwin-patches
On Jan 19 00:00, Takashi Yano via Cygwin-patches wrote:
> Hi Corinna,
>
> On Fri, 15 Jan 2021 18:26:31 +0900
> Takashi Yano wrote:
> > - cat exits immediately in the following senario.
> > 1) Execute env CYGWIN=disable_pcon script
> > 2) Execute cmd.exe
> > 3) Execute cat in cmd.exe.
> > This is caused by setting input_available_event for the pipe for
> > non-cygwin app. This patch fixes the issue.
> > ---
> > winsup/cygwin/fhandler_tty.cc | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > index e4993bf31..0b9901974 100644
> > --- a/winsup/cygwin/fhandler_tty.cc
> > +++ b/winsup/cygwin/fhandler_tty.cc
> > @@ -394,7 +394,8 @@ fhandler_pty_master::accept_input ()
> > }
> > }
> >
> > - SetEvent (input_available_event);
> > + if (write_to == get_output_handle ())
> > + SetEvent (input_available_event);
> > ReleaseMutex (input_mutex);
> > return ret;
> > }
> > --
> > 2.30.0
> >
>
> I would be happy if you could review this patch as well.
Sorry, I missed that one! Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe.
2021-01-18 15:27 ` Corinna Vinschen
@ 2021-01-18 15:41 ` Takashi Yano
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Yano @ 2021-01-18 15:41 UTC (permalink / raw)
To: cygwin-patches
On Mon, 18 Jan 2021 16:27:00 +0100
Corinna Vinschen wrote:
> On Jan 19 00:00, Takashi Yano via Cygwin-patches wrote:
> > Hi Corinna,
> >
> > On Fri, 15 Jan 2021 18:26:31 +0900
> > Takashi Yano wrote:
> > > - cat exits immediately in the following senario.
> > > 1) Execute env CYGWIN=disable_pcon script
> > > 2) Execute cmd.exe
> > > 3) Execute cat in cmd.exe.
> > > This is caused by setting input_available_event for the pipe for
> > > non-cygwin app. This patch fixes the issue.
> > > ---
> > > winsup/cygwin/fhandler_tty.cc | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > > index e4993bf31..0b9901974 100644
> > > --- a/winsup/cygwin/fhandler_tty.cc
> > > +++ b/winsup/cygwin/fhandler_tty.cc
> > > @@ -394,7 +394,8 @@ fhandler_pty_master::accept_input ()
> > > }
> > > }
> > >
> > > - SetEvent (input_available_event);
> > > + if (write_to == get_output_handle ())
> > > + SetEvent (input_available_event);
> > > ReleaseMutex (input_mutex);
> > > return ret;
> > > }
> > > --
> > > 2.30.0
> > >
> >
> > I would be happy if you could review this patch as well.
>
> Sorry, I missed that one! Pushed.
Thanks!
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-18 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 9:26 [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe Takashi Yano
2021-01-18 15:00 ` Takashi Yano
2021-01-18 15:27 ` Corinna Vinschen
2021-01-18 15:41 ` Takashi Yano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).