From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: fhandler_serial.cc: MARK and SPACE parity for serial port
Date: Thu, 28 Jan 2021 11:14:29 +0100 [thread overview]
Message-ID: <20210128101429.GX4393@calimero.vinschen.de> (raw)
In-Reply-To: <20210128100802.GW4393@calimero.vinschen.de>
Oh, btw...
On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote:
> Hi Marek,
>
> thanks for the patch. [...]
> > index 17e8d83a3..933851c21 100644
> > --- a/winsup/cygwin/include/sys/termios.h
> > +++ b/winsup/cygwin/include/sys/termios.h
> > @@ -185,6 +185,7 @@ POSIX commands */
> > #define PARODD 0x00200
> > #define HUPCL 0x00400
> > #define CLOCAL 0x00800
> > +#define CMSPAR 0x40000000 /* Mark or space (stick) parity. */
Why did you choose such a big value here? Wouldn't it be nicer just to
follow up with
#define CMSPAR 0x10000
or am I missing something here?
Also, on second thought I think CMSPAR should follow CRTSCTS, a few
lines below, because of its numerical value higher than CRTSCTS.
Thanks,
Corinna
next prev parent reply other threads:[~2021-01-28 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 20:30 Marek Smetana
2021-01-28 10:08 ` Corinna Vinschen
2021-01-28 10:14 ` Corinna Vinschen [this message]
2021-01-28 17:17 ` Brian Inglis
2021-01-28 18:45 ` Brian Inglis
2021-01-29 22:06 ` Marek Smetana
2021-02-01 9:40 ` Corinna Vinschen
2021-02-01 21:26 ` Marek Smetana
2021-02-02 5:28 ` Brian Inglis
2021-02-02 9:44 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128101429.GX4393@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).