public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: cygwin-patches@cygwin.com
Subject: Re: fhandler_serial.cc: MARK and SPACE parity for serial port
Date: Mon, 1 Feb 2021 22:28:23 -0700	[thread overview]
Message-ID: <9257129f-ad1d-6be1-e9c5-d77dc3c658cf@SystematicSw.ab.ca> (raw)
In-Reply-To: <ff9e2845-7a5c-945c-f742-a79d65ab5909@gmail.com>

On 2021-02-01 14:26, Marek Smetana via Cygwin-patches wrote:
> I'm Sorry, this is my first patch using the mailing list.

I too struggled for ages getting these right;
first set up your ~/.gitconfig something like:

$ grep -v '^#' ~/.gitconfig
[user]
         name = ...
         email = ...

[sendemail]
         bcc = ...
         smtpServer = ...
         confirm = always

[core]
         editor = /usr/bin/gvim -f

When you commit your changes, the first line of the commit message becomes your 
patch file name and email subject, so keep it < 63, leave a blank line, then 
expand on the details in subsequent lines < 80, so I find it easier to run:

$ git diff @^ > COMMIT_MSG

hack away at that then:

$ git commit -F COMMIT_MSG ...

$ git format-patch --to=cygwin-patches@cygwin.com -1

which will write a file like:

0001-fhandler_serial.cc-MARK-and-SPACE-parity-for-serial-port.patch

hack away at that to improve it then:

$ git send-email --to=cygwin-patches@cygwin.com \
	0001-fhandler_serial.cc-MARK-and-SPACE-parity-for-serial-port.patch

and answer the confirmation message if you enabled that above.

Does anyone know of a way to set different default patch email addresses for 
newlib/ and winsup/ trees?

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]

  reply	other threads:[~2021-02-02  5:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 20:30 Marek Smetana
2021-01-28 10:08 ` Corinna Vinschen
2021-01-28 10:14   ` Corinna Vinschen
2021-01-28 17:17     ` Brian Inglis
2021-01-28 18:45       ` Brian Inglis
2021-01-29 22:06     ` Marek Smetana
2021-02-01  9:40       ` Corinna Vinschen
2021-02-01 21:26         ` Marek Smetana
2021-02-02  5:28           ` Brian Inglis [this message]
2021-02-02  9:44           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9257129f-ad1d-6be1-e9c5-d77dc3c658cf@SystematicSw.ab.ca \
    --to=brian.inglis@systematicsw.ab.ca \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).