public inbox for
 help / color / mirror / Atom feed
From: Corinna Vinschen <>
Cc: Pierre Humblet <>
Subject: Re: [PATCH] CYGWIN:  Fix resolver debugging output
Date: Mon, 1 Feb 2021 11:34:45 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Anton,

On Jan 29 14:29, Anton Lavrentiev via Cygwin-patches wrote:
> - Use %S (instead of %s) when a wide-character output is due;

Please use %ls, %S is non-standard.

> - Use native byte order for host and add port when doing I/O with DNS server;

This puzzeled me a bit so I took another look into the original code.
Do I see this right that we have only limited IPv6 support in the
resolver code?  For instance, write_record appears to handle DNS_TYPE_A,
but not DNS_TYPE_AAAA.

CCing Pierre, hopefully he's still around.  Pierre, can you please
have a look and suggest how to go forward here?

> - Use forward way for resolv.conf's "options" processing, so listing "debug" as a
>   first option, will show all following option(s) as they are read;
> - Re-evaluate debug output flag after each "options" processing as it may chance.

Would you mind to split this into a patchset with patches for different
tasks?  ATM I'm a bit concerned about the ntoh{sl} calls, given the
noticable absence of IPv6 support...


  reply	other threads:[~2021-02-01 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 19:29 Anton Lavrentiev
2021-02-01 10:34 ` Corinna Vinschen [this message]
2021-02-01 14:23   ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2021-02-01 15:02     ` Corinna Vinschen
2021-02-01 15:46       ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2021-02-01 19:02         ` Corinna Vinschen
2021-02-02 18:02           ` Brian Inglis
2021-02-02 19:38             ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).