From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] CYGWIN: Fix resolver debugging output
Date: Mon, 1 Feb 2021 16:02:09 +0100 [thread overview]
Message-ID: <20210201150209.GP375565@calimero.vinschen.de> (raw)
In-Reply-To: <DM8PR09MB7095CE3228ED706E16BA0F16A5B69@DM8PR09MB7095.namprd09.prod.outlook.com>
On Feb 1 14:23, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote:
> > Please use %ls, %S is non-standard.
>
> Sure.
>
> > For instance, write_record appears to handle DNS_TYPE_A,
> > but not DNS_TYPE_AAAA.
>
> I can add that, it's not a problem. But indeed, reparsing of Windows packets,
> does miss AAAA (as well as some other types, such as URI -- not sure if Windows
> has it, though).
>
> > Would you mind to split this into a patchset with patches for different
> > tasks? ATM I'm a bit concerned about the ntoh{sl} calls, given the
> > noticable absence of IPv6 support...
>
> Okay. BTW, I added ntol/s only for output of *nameserver*'s IPv4:port, because
> nameservers are IPv4 (even in glibc, AFAIK). The _res structure (same in glibc)
> has these addresses as "struct in_addr", meaning they are IPv4.
But nameservers could be v6 addresses nevertheless, and the values are
stored in the _ext.nsaddrs member these days. Our definition of
_res_state does not define all the members of _ext as GLibc defines,
though, and our resolver code doesn't use _ext at all, afaics.
> And so there's
> no risk of running into any troubles, but reading the IP addresses in debug output
> is much easier if they are in native order (and same goes for ports, even more).
Except, the value has no meaning for ipv6.
Corinna
next prev parent reply other threads:[~2021-02-01 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:29 Anton Lavrentiev
2021-02-01 10:34 ` Corinna Vinschen
2021-02-01 14:23 ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2021-02-01 15:02 ` Corinna Vinschen [this message]
2021-02-01 15:46 ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2021-02-01 19:02 ` Corinna Vinschen
2021-02-02 18:02 ` Brian Inglis
2021-02-02 19:38 ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201150209.GP375565@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).