public inbox for
 help / color / mirror / Atom feed
From: Takashi Yano <>
Subject: [PATCH] Cygwin: console: Prevent NULL pointer access in close().
Date: Mon, 22 Feb 2021 22:30:17 +0900	[thread overview]
Message-ID: <> (raw)

- There seems to be a case that shared_console_info is not set yet
  when close() is called. This patch adds guard for such case.
 winsup/cygwin/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/ b/winsup/cygwin/
index 6ded9eabf..96a8729e8 100644
--- a/winsup/cygwin/
+++ b/winsup/cygwin/
@@ -1393,7 +1393,7 @@ fhandler_console::close ()
   release_output_mutex ();
-  if (con.owner == myself->pid)
+  if (shared_console_info && con.owner == myself->pid)
       char name[MAX_PATH];
       shared_name (name, CONS_THREAD_SYNC, get_minor ());

             reply	other threads:[~2021-02-22 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 13:30 Takashi Yano [this message]
2021-02-22 13:58 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).