From: Mark Geisert <mark@maxrnd.com>
To: cygwin-patches@cygwin.com
Subject: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit
Date: Wed, 6 Oct 2021 22:22:37 -0700 [thread overview]
Message-ID: <20211007052237.7139-1-mark@maxrnd.com> (raw)
This allows correct copy and pasting between the two Cygwin flavors.
What's done is to overlay the differing timespec formats via a union
within the control structure cygcb_t. Then conversion between the two
formats is done on the 32-bit side only.
The cygutils package has two programs, putclip and getclip, that also
depend on the layout of the cygcb_t. At present they have duplicate
defs of struct cygcb_t defined here as no Cygwin header provides it.
---
winsup/cygwin/fhandler_clipboard.cc | 39 +++++++++++++++++++++--------
1 file changed, 28 insertions(+), 11 deletions(-)
diff --git a/winsup/cygwin/fhandler_clipboard.cc b/winsup/cygwin/fhandler_clipboard.cc
index ccdb295f3..649e57072 100644
--- a/winsup/cygwin/fhandler_clipboard.cc
+++ b/winsup/cygwin/fhandler_clipboard.cc
@@ -28,9 +28,16 @@ static const WCHAR *CYGWIN_NATIVE = L"CYGWIN_NATIVE_CLIPBOARD";
typedef struct
{
- timestruc_t timestamp;
- size_t len;
- char data[1];
+ union
+ {
+ struct timespec ts; // 8 bytes on 32-bit Cygwin, 16 bytes on 64-bit Cygwin
+ struct
+ {
+ uint64_t cb_sec;
+ uint64_t cb_nsec;
+ };
+ };
+ uint64_t cb_size;
} cygcb_t;
fhandler_dev_clipboard::fhandler_dev_clipboard ()
@@ -74,9 +81,14 @@ fhandler_dev_clipboard::set_clipboard (const void *buf, size_t len)
}
clipbuf = (cygcb_t *) GlobalLock (hmem);
- clock_gettime (CLOCK_REALTIME, &clipbuf->timestamp);
- clipbuf->len = len;
- memcpy (clipbuf->data, buf, len);
+ clock_gettime (CLOCK_REALTIME, &clipbuf->ts);
+#ifndef __x86_64__
+ // expand 32-bit timespec layout to 64-bit layout
+ clipbuf->cb_nsec = clipbuf->ts.tv_nsec;
+ clipbuf->cb_sec = clipbuf->ts.tv_sec;
+#endif
+ clipbuf->cb_size = len;
+ memcpy (&clipbuf[1], buf, len); // append data
GlobalUnlock (hmem);
EmptyClipboard ();
@@ -179,8 +191,13 @@ fhandler_dev_clipboard::fstat (struct stat *buf)
&& (hglb = GetClipboardData (format))
&& (clipbuf = (cygcb_t *) GlobalLock (hglb)))
{
- buf->st_atim = buf->st_mtim = clipbuf->timestamp;
- buf->st_size = clipbuf->len;
+#ifndef __x86_64__
+ // compress 64-bit timespec layout to 32-bit layout
+ clipbuf->ts.tv_sec = clipbuf->cb_sec;
+ clipbuf->ts.tv_nsec = clipbuf->cb_nsec;
+#endif
+ buf->st_atim = buf->st_mtim = clipbuf->ts;
+ buf->st_size = clipbuf->cb_size;
GlobalUnlock (hglb);
}
CloseClipboard ();
@@ -218,10 +235,10 @@ fhandler_dev_clipboard::read (void *ptr, size_t& len)
{
cygcb_t *clipbuf = (cygcb_t *) cb_data;
- if (pos < (off_t) clipbuf->len)
+ if (pos < (off_t) clipbuf->cb_size)
{
- ret = ((len > (clipbuf->len - pos)) ? (clipbuf->len - pos) : len);
- memcpy (ptr, clipbuf->data + pos , ret);
+ ret = (len > (clipbuf->cb_size - pos)) ? clipbuf->cb_size - pos : len;
+ memcpy (ptr, &clipbuf[1] + pos , ret);
pos += ret;
}
}
--
2.33.0
next reply other threads:[~2021-10-07 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 5:22 Mark Geisert [this message]
2021-10-07 5:56 ` Mark Geisert
2021-10-08 9:52 ` Takashi Yano
2021-10-09 14:19 ` Ken Brown
2021-10-09 14:29 ` Jon Turney
2021-10-09 14:43 ` Ken Brown
2021-10-11 6:13 ` Mark Geisert
2021-10-11 12:11 ` Ken Brown
2021-10-22 15:11 ` Corinna Vinschen
2021-10-23 5:35 ` Mark Geisert
2021-10-23 20:32 ` Ken Brown
2021-10-23 21:53 ` Mark Geisert
2021-10-23 23:58 ` Takashi Yano
2021-10-25 8:28 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007052237.7139-1-mark@maxrnd.com \
--to=mark@maxrnd.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).