From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit
Date: Sun, 24 Oct 2021 08:58:23 +0900 [thread overview]
Message-ID: <20211024085823.909b894a0ae6c604f0216582@nifty.ne.jp> (raw)
In-Reply-To: <YXLUkU6Nc3qAXLyp@calimero.vinschen.de>
Hi Corinna,
On Fri, 22 Oct 2021 17:11:13 +0200
Corinna Vinschen wrote:
> Just to close this up prior to the 3.3.0 release...
>
> Given we never actually strived for 32<->64 bit interoperability, it's
> hard to argue why this should be different for the clipboard stuff.
>
> Running 32 and 64 bit Cygwin versions in parallel doesn't actually make
> much sense for most people anyway, unless they explicitely develop for
> 32 and 64 bit systems under Cygwin. From a productivity point of view
> there's no good reason to run more than one arch.
>
> So I agree with Ken here. It's probably not worth the trouble.
Current code below in fhandler_clipboard.cc causes access violation
if clipboard is accessed between 32 and 64 bit cygwin.
cygcb_t *clipbuf = (cygcb_t *) cb_data;
if (pos < (off_t) clipbuf->len)
{
ret = ((len > (clipbuf->len - pos)) ? (clipbuf->len - pos) : len);
memcpy (ptr, clipbuf->data + pos , ret);
pos += ret;
}
Don't you think this should be fixed?
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-10-23 23:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 5:22 Mark Geisert
2021-10-07 5:56 ` Mark Geisert
2021-10-08 9:52 ` Takashi Yano
2021-10-09 14:19 ` Ken Brown
2021-10-09 14:29 ` Jon Turney
2021-10-09 14:43 ` Ken Brown
2021-10-11 6:13 ` Mark Geisert
2021-10-11 12:11 ` Ken Brown
2021-10-22 15:11 ` Corinna Vinschen
2021-10-23 5:35 ` Mark Geisert
2021-10-23 20:32 ` Ken Brown
2021-10-23 21:53 ` Mark Geisert
2021-10-23 23:58 ` Takashi Yano [this message]
2021-10-25 8:28 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211024085823.909b894a0ae6c604f0216582@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).