From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH 2/3] Cygwin: pty: Fix console mode of non-cygwin apps in background.
Date: Sun, 12 Dec 2021 22:05:00 +0900 [thread overview]
Message-ID: <20211212130501.10091-3-takashi.yano@nifty.ne.jp> (raw)
In-Reply-To: <20211212130501.10091-1-takashi.yano@nifty.ne.jp>
- If the non-cygwin app is started in the background in pseudo
console, the console mode is broken for the app. This patch fixes
the issue.
---
winsup/cygwin/fhandler_tty.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 904398179..cd0de9bc0 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -3384,7 +3384,7 @@ skip_create:
if (get_ttyp ()->previous_output_code_page)
SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
- do
+ if (get_ttyp ()->getpgid () == myself->pgid)
{
termios &t = get_ttyp ()->ti;
DWORD mode;
@@ -3409,7 +3409,6 @@ skip_create:
mode |= DISABLE_NEWLINE_AUTO_RETURN;
SetConsoleMode (hpConOut, mode);
}
- while (false);
return true;
--
2.34.1
next prev parent reply other threads:[~2021-12-12 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 13:04 [PATCH 0/3] Fix behaviour " Takashi Yano
2021-12-12 13:04 ` [PATCH 1/3] Cygwin: pty: Fix Ctrl-C handling for " Takashi Yano
2021-12-12 13:05 ` Takashi Yano [this message]
2021-12-12 13:05 ` [PATCH 3/3] Cygwin: console: Fix console mode of " Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211212130501.10091-3-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).