From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH 3/3] Cygwin: console: Fix console mode of non-cygwin apps in background.
Date: Sun, 12 Dec 2021 22:05:01 +0900 [thread overview]
Message-ID: <20211212130501.10091-4-takashi.yano@nifty.ne.jp> (raw)
In-Reply-To: <20211212130501.10091-1-takashi.yano@nifty.ne.jp>
- If the non-cygwin app is started in the background in console, the
console mode is broken for the app. This patch fixes the issue.
---
winsup/cygwin/spawn.cc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index e160fa3bb..465fb5fc3 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -631,11 +631,14 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
cons_ti = &((tty *)cons->tc ())->ti;
cons_owner = cons->get_owner ();
}
+ tty::cons_mode conmode =
+ (ctty_pgid && ctty_pgid == myself->pgid) ?
+ tty::native : tty::restore;
if (fd == 0)
- fhandler_console::set_input_mode (tty::native,
+ fhandler_console::set_input_mode (conmode,
cons_ti, cons->get_handle_set ());
else if (fd == 1 || fd == 2)
- fhandler_console::set_output_mode (tty::native,
+ fhandler_console::set_output_mode (conmode,
cons_ti, cons->get_handle_set ());
}
}
--
2.34.1
prev parent reply other threads:[~2021-12-12 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 13:04 [PATCH 0/3] Fix behaviour " Takashi Yano
2021-12-12 13:04 ` [PATCH 1/3] Cygwin: pty: Fix Ctrl-C handling for " Takashi Yano
2021-12-12 13:05 ` [PATCH 2/3] Cygwin: pty: Fix console mode of " Takashi Yano
2021-12-12 13:05 ` Takashi Yano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211212130501.10091-4-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).