From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] fhandler_pipe: add sanity limit to handle loops
Date: Sun, 26 Dec 2021 02:10:10 +0900 [thread overview]
Message-ID: <20211226021010.a2b2ad28f12df9ffb25b6584@nifty.ne.jp> (raw)
In-Reply-To: <alpine.BSO.2.21.2112242101520.11760@resin.csoft.net>
On Fri, 24 Dec 2021 21:40:24 -0800 (PST)
Jeremy Drake wrote:
> On Sat, 25 Dec 2021, Takashi Yano wrote:
>
> > On Fri, 24 Dec 2021 19:47:46 -0800 (PST)
> > Jeremy Drake wrote:
> > > phi->NumberOfHandles = 7999168, n_handle = 256
> > > assertion "phi->NumberOfHandles <= n_handle" failed: file
> > > "../../.././winsup/cygwin/fhandler_pipe.cc", line 1280, function: void*
> > > fhandler_pipe::get_query_hdl_per_process(WCHAR*, OBJECT_NAME_INFORMATION*)
> > > Aborted
> >
> > What!? Could you please check value of the "status" ?
>
> status = 0x00000000, phi->NumberOfHandles = 7286688, n_handle = 256
> assertion "phi->NumberOfHandles <= n_handle" failed: file
> "../../.././winsup/cygwin/fhandler_pipe.cc", line 1281, function: void*
> fhandler_pipe::get_query_hdl_per_process(WCHAR*, OBJECT_NAME_INFORMATION*)
> Aborted
>
> > What version of windows do you use?
>
> This was on Windows 11 (22000.376) on ARM64, but msys2 has started seeing
> similar hangs on Github's "windows-2022" runner. I don't have one of
> those locally to test against however. But if push came to shove, I think
> I downloaded a Server 2022 evaluation ISO, I could set up a VM and see
> what happens.
Could you please check the result of the following test case
in that ARM64 platform?
The following code can be compiled using mingw compiper with
-lntdll flag.
#include <windows.h>
#include <ntdef.h>
#include <ntstatus.h>
#include <stdlib.h>
#include <stdio.h>
typedef enum
{
ProcessHandleInformation = 51 /* Since Win8 */
} PROCESSINFOCLASS;
typedef struct
{
HANDLE HandleValue;
ULONG_PTR HandleCount;
ULONG_PTR PointerCount;
ULONG GrantedAccess;
ULONG ObjectTypeIndex;
ULONG HandleAttributes;
ULONG Reserved;
} PROCESS_HANDLE_TABLE_ENTRY_INFO, *PPROCESS_HANDLE_TABLE_ENTRY_INFO;
typedef struct
{
ULONG_PTR NumberOfHandles;
ULONG_PTR Reserved;
PROCESS_HANDLE_TABLE_ENTRY_INFO Handles[1];
} PROCESS_HANDLE_SNAPSHOT_INFORMATION;
NTSTATUS NTAPI NtQueryInformationProcess (HANDLE, PROCESSINFOCLASS,
PVOID, ULONG, PULONG);
typedef enum
{
SystemHandleInformation = 16
} SYSTEM_INFORMATION_CLASS;
typedef struct
{
USHORT UniqueProcessId;
USHORT CreatorBackTraceIndex;
UCHAR ObjectTypeIndex;
UCHAR HandleAttributes;
USHORT HandleValue;
PVOID Object;
ULONG GrantedAccess;
} SYSTEM_HANDLE_TABLE_ENTRY_INFO;
typedef struct
{
ULONG NumberOfHandles;
SYSTEM_HANDLE_TABLE_ENTRY_INFO Handles[1];
} SYSTEM_HANDLE_INFORMATION;
NTSTATUS NTAPI NtQuerySystemInformation (SYSTEM_INFORMATION_CLASS,
PVOID, ULONG, PULONG);
int main()
{
NTSTATUS status;
DWORD n_handle = 1;
PROCESS_HANDLE_SNAPSHOT_INFORMATION *phi;
do {
DWORD nbytes = 2 * sizeof(ULONG_PTR)
+ n_handle * sizeof(PROCESS_HANDLE_TABLE_ENTRY_INFO);
phi = (PROCESS_HANDLE_SNAPSHOT_INFORMATION *)
HeapAlloc(GetProcessHeap(), 0, nbytes);
if (!phi) {
fprintf(stderr, "HeapAlloc() Error: %08x\n", GetLastError());
exit(1);
}
ULONG len;
status = NtQueryInformationProcess(GetCurrentProcess(),
ProcessHandleInformation, phi, nbytes, &len);
if (NT_SUCCESS (status)) break;
HeapFree(GetProcessHeap(), 0, phi);
n_handle ++;
} while (status == STATUS_INFO_LENGTH_MISMATCH);
if (!NT_SUCCESS (status)) {
fprintf(stderr, "NtQueryInformationProcess() error: %08x\n", status);
HeapFree(GetProcessHeap(), 0, phi);
exit(1);
}
printf("per_process: n_handle=%d, NumberOfHandles=%d\n",
n_handle, phi->NumberOfHandles);
if (phi->NumberOfHandles > n_handle) {
HeapFree(GetProcessHeap(), 0, phi);
exit(1);
}
HeapFree(GetProcessHeap(), 0, phi);
n_handle = 1;
SYSTEM_HANDLE_INFORMATION *shi;
do {
SIZE_T nbytes = sizeof(ULONG)
+ n_handle * sizeof(SYSTEM_HANDLE_TABLE_ENTRY_INFO);
shi = (SYSTEM_HANDLE_INFORMATION *) HeapAlloc (GetProcessHeap(),
0, nbytes);
if (!shi) {
fprintf(stderr, "HeapAlloc() Error: %08x\n", GetLastError());
exit(1);
}
status = NtQuerySystemInformation(SystemHandleInformation,
shi, nbytes, NULL);
if (NT_SUCCESS(status)) break;
HeapFree (GetProcessHeap(), 0, shi);
n_handle *= 2;
} while (status == STATUS_INFO_LENGTH_MISMATCH);
if (!NT_SUCCESS (status)) {
fprintf(stderr, "NtQuerySystemInformation() error: %08x\n", status);
HeapFree(GetProcessHeap(), 0, shi);
exit(1);
}
printf("per_system: n_handle=%d, NumberOfHandles=%d\n",
n_handle, shi->NumberOfHandles);
if (shi->NumberOfHandles > n_handle) {
HeapFree(GetProcessHeap(), 0, shi);
exit(1);
}
HeapFree(GetProcessHeap(), 0, shi);
return 0;
}
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-12-25 17:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 23:10 Jeremy Drake
2021-12-24 0:06 ` Ken Brown
2021-12-24 0:29 ` Jeremy Drake
2021-12-24 17:17 ` Ken Brown
2021-12-24 19:42 ` Jeremy Drake
2021-12-24 22:46 ` Ken Brown
2021-12-24 23:42 ` Jeremy Drake
2021-12-25 0:39 ` Jeremy Drake
2021-12-25 3:19 ` Takashi Yano
2021-12-25 3:47 ` Jeremy Drake
2021-12-25 4:12 ` Takashi Yano
2021-12-25 5:40 ` Jeremy Drake
2021-12-25 17:10 ` Takashi Yano [this message]
2021-12-25 17:16 ` Takashi Yano
2021-12-25 19:00 ` Marco Atzeri
2021-12-25 19:20 ` Jeremy Drake
2021-12-25 22:18 ` Ken Brown
2021-12-25 23:00 ` Jeremy Drake
2021-12-26 3:04 ` Ken Brown
2021-12-26 4:56 ` Jeremy Drake
2021-12-26 15:09 ` Ken Brown
2021-12-26 16:04 ` Ken Brown
2021-12-26 16:24 ` Ken Brown
2021-12-26 21:35 ` Jeremy Drake
2021-12-26 22:18 ` Ken Brown
2021-12-26 22:43 ` Jeremy Drake
2021-12-26 23:12 ` Ken Brown
2021-12-26 23:23 ` Jeremy Drake
2021-12-27 2:42 ` Ken Brown
2021-12-27 21:12 ` Jeremy Drake
2021-12-29 21:59 ` Ken Brown
2021-12-29 23:29 ` Jeremy Drake
2021-12-27 20:01 ` Jon Turney
2021-12-29 5:45 ` Jeremy Drake
2021-12-30 15:44 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211226021010.a2b2ad28f12df9ffb25b6584@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).