From: Ken Brown <kbrown@cornell.edu>
To: Jeremy Drake <cygwin@jdrake.com>
Cc: cygwin-patches@cygwin.com
Subject: Re: [PATCH] fhandler_pipe: add sanity limit to handle loops
Date: Sun, 26 Dec 2021 11:24:40 -0500 [thread overview]
Message-ID: <317dc73a-fb9d-3937-7354-c79492c1c64c@cornell.edu> (raw)
In-Reply-To: <d2af0b22-666a-b820-acb0-afc835836372@cornell.edu>
On 12/26/2021 11:04 AM, Ken Brown wrote:
> On 12/26/2021 10:09 AM, Ken Brown wrote:
>> 1. For some processes, NtQueryInformationProcess(ProcessHandleInformation) can
>> return STATUS_SUCCESS with invalid handle information. See the comment
>> starting at line 5754, where it is shown how to detect this.
>
> If I'm right, the following patch should fix the problem:
>
> diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
> index ba6b70f55..4cef3e4ca 100644
> --- a/winsup/cygwin/fhandler_pipe.cc
> +++ b/winsup/cygwin/fhandler_pipe.cc
> @@ -1228,6 +1228,7 @@ fhandler_pipe::get_query_hdl_per_process (WCHAR *name,
> HeapAlloc (GetProcessHeap (), 0, nbytes);
> if (!phi)
> goto close_proc;
> + phi->NumberOfHandles = 0;
> status = NtQueryInformationProcess (proc, ProcessHandleInformation,
> phi, nbytes, &len);
> if (NT_SUCCESS (status))
Actually, this first hunk should suffice.
> @@ -1238,6 +1239,11 @@ fhandler_pipe::get_query_hdl_per_process (WCHAR *name,
> while (n_handle < (1L<<20) && status == STATUS_INFO_LENGTH_MISMATCH);
> if (!NT_SUCCESS (status))
> goto close_proc;
> + if (phi->NumberOfHandles == 0)
> + {
> + HeapFree (GetProcessHeap (), 0, phi);
> + goto close_proc;
> + }
>
> for (ULONG j = 0; j < phi->NumberOfHandles; j++)
> {
>
> Jeremy, could you try this?
>
> Ken
next prev parent reply other threads:[~2021-12-26 16:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 23:10 Jeremy Drake
2021-12-24 0:06 ` Ken Brown
2021-12-24 0:29 ` Jeremy Drake
2021-12-24 17:17 ` Ken Brown
2021-12-24 19:42 ` Jeremy Drake
2021-12-24 22:46 ` Ken Brown
2021-12-24 23:42 ` Jeremy Drake
2021-12-25 0:39 ` Jeremy Drake
2021-12-25 3:19 ` Takashi Yano
2021-12-25 3:47 ` Jeremy Drake
2021-12-25 4:12 ` Takashi Yano
2021-12-25 5:40 ` Jeremy Drake
2021-12-25 17:10 ` Takashi Yano
2021-12-25 17:16 ` Takashi Yano
2021-12-25 19:00 ` Marco Atzeri
2021-12-25 19:20 ` Jeremy Drake
2021-12-25 22:18 ` Ken Brown
2021-12-25 23:00 ` Jeremy Drake
2021-12-26 3:04 ` Ken Brown
2021-12-26 4:56 ` Jeremy Drake
2021-12-26 15:09 ` Ken Brown
2021-12-26 16:04 ` Ken Brown
2021-12-26 16:24 ` Ken Brown [this message]
2021-12-26 21:35 ` Jeremy Drake
2021-12-26 22:18 ` Ken Brown
2021-12-26 22:43 ` Jeremy Drake
2021-12-26 23:12 ` Ken Brown
2021-12-26 23:23 ` Jeremy Drake
2021-12-27 2:42 ` Ken Brown
2021-12-27 21:12 ` Jeremy Drake
2021-12-29 21:59 ` Ken Brown
2021-12-29 23:29 ` Jeremy Drake
2021-12-27 20:01 ` Jon Turney
2021-12-29 5:45 ` Jeremy Drake
2021-12-30 15:44 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317dc73a-fb9d-3937-7354-c79492c1c64c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
--cc=cygwin@jdrake.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).