* [PATCH] Cygwin: dsp: Avoid setting buffer that is too small.
@ 2023-09-17 13:09 Takashi Yano
0 siblings, 0 replies; only message in thread
From: Takashi Yano @ 2023-09-17 13:09 UTC (permalink / raw)
To: cygwin-patches; +Cc: Takashi Yano
The buffer size that is too small causes choppy sound. That is not
practical at all. With this patch, the minimum value of the buffer
size (i.e. fragstotal * fragsize) is restricted to 16384 bytes.
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
---
winsup/cygwin/fhandler/dsp.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/winsup/cygwin/fhandler/dsp.cc b/winsup/cygwin/fhandler/dsp.cc
index 7459ddc25..6140ef0c2 100644
--- a/winsup/cygwin/fhandler/dsp.cc
+++ b/winsup/cygwin/fhandler/dsp.cc
@@ -1434,6 +1434,8 @@ fhandler_dev_dsp::_ioctl (unsigned int cmd, void *buf)
int *p = (int *) buf;
fragstotal_ = min (*p >> 16, MAX_BLOCKS);
fragsize_ = 1 << (*p & 0xffff);
+ while (fragsize_ * fragstotal_ < 16384)
+ fragsize_ *= 2;
fragment_has_been_set = true;
return 0;
}
--
2.39.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-17 13:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-17 13:09 [PATCH] Cygwin: dsp: Avoid setting buffer that is too small Takashi Yano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).