From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.
Date: Sun, 3 Mar 2024 19:21:09 +0900 [thread overview]
Message-ID: <20240303192109.9fb4a3a4968bb11ca5d9636a@nifty.ne.jp> (raw)
In-Reply-To: <b0bd6b96-5bd8-7f4e-71ff-4552e5ac1cb5@gmx.de>
On Sun, 3 Mar 2024 10:34:44 +0100 (CET)
Johannes Schindelin wrote:
> Hi Takashi,
>
> thank you for the fix! I can confirm that it addresses the problem
> demonstrated by the reproducer in that MSYS2-runtime ticket.
Thanks for testing!
> After noticing that we enumerate all the processes (which is an expensive
> operation) just to skip all of the non-Cygwin ones anyway, I wonder if it
> wouldn't be smarter to go through the internal list of cygpids and take it
> from there, skipping the `SystemProcessInformation` calls altogether.
Yeah, that makes sens. I'll submit v2 patch.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2024-03-03 10:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 5:09 Takashi Yano
2024-03-03 9:34 ` Johannes Schindelin
2024-03-03 10:21 ` Takashi Yano [this message]
2024-03-03 10:39 ` ASSI
2024-03-03 11:36 ` Takashi Yano
2024-03-04 10:34 ` Corinna Vinschen
2024-03-04 15:45 ` ASSI
2024-03-04 17:38 ` Corinna Vinschen
2024-03-05 0:06 ` Takashi Yano
2024-03-05 10:14 ` Corinna Vinschen
2024-03-05 14:47 ` Takashi Yano
2024-03-05 16:54 ` Corinna Vinschen
2024-03-05 18:42 ` Takashi Yano
2024-03-05 18:46 ` Takashi Yano
2024-03-06 12:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303192109.9fb4a3a4968bb11ca5d9636a@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).