From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps.
Date: Wed, 6 Mar 2024 13:54:27 +0100 [thread overview]
Message-ID: <Zehng9EELCgrrnBA@calimero.vinschen.de> (raw)
In-Reply-To: <20240306034223.4d02b898542324431341b2bb@nifty.ne.jp>
On Mar 6 03:42, Takashi Yano wrote:
> On Tue, 5 Mar 2024 17:54:19 +0100
> Corinna Vinschen wrote:
> > On Mar 5 23:47, Takashi Yano wrote:
> > > On Tue, 5 Mar 2024 11:14:46 +0100
> > > Corinna Vinschen wrote:
> > > > This doesn't affect your patch, but while looking into this, what
> > > > strikes me as weird is that fhandler_pipe::temporary_query_hdl() calls
> > > > NtQueryObject() and assembles the pipe name via swscanf() every time it
> > > > is called.
> > > >
> > > > Wouldn't it make sense to store the name in the fhandler's
> > > > path_conv::wide_path/uni_path at creation time instead?
> > > > The wide_path member is not used at all in pipes, ostensibly.
> > >
> > > Is the patch attached as you intended?
> >
> > Yes, but it looks like it misses a few potential simplifications:
> > [...]
> Thanks for advice. I have revised the patch.
Looks good, thanks!
Corinna
prev parent reply other threads:[~2024-03-06 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 5:09 Takashi Yano
2024-03-03 9:34 ` Johannes Schindelin
2024-03-03 10:21 ` Takashi Yano
2024-03-03 10:39 ` ASSI
2024-03-03 11:36 ` Takashi Yano
2024-03-04 10:34 ` Corinna Vinschen
2024-03-04 15:45 ` ASSI
2024-03-04 17:38 ` Corinna Vinschen
2024-03-05 0:06 ` Takashi Yano
2024-03-05 10:14 ` Corinna Vinschen
2024-03-05 14:47 ` Takashi Yano
2024-03-05 16:54 ` Corinna Vinschen
2024-03-05 18:42 ` Takashi Yano
2024-03-05 18:46 ` Takashi Yano
2024-03-06 12:54 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zehng9EELCgrrnBA@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).