public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowitz@cygwin.com>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Use automake (v3)
Date: Wed, 02 Dec 2020 13:33:03 -0500	[thread overview]
Message-ID: <42d8f1f139939b45fef85d00c3e368cf2500b603.camel@cygwin.com> (raw)
In-Reply-To: <161bd779-bd17-1e98-5644-bea42c3206cf@dronecode.org.uk>

On Wed, 2020-12-02 at 18:03 +0000, Jon Turney wrote:
> On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote:
> > On Dec  2 15:36, Jon Turney wrote:
> > > On 01/12/2020 09:18, Corinna Vinschen wrote:
> > > > What bugs me is that the mingw executables are built in
> > > > utils/mingw,
> > > > but the object files are still in utils.  Any problem
> > > > generating the
> > > > object files in utils/mingw, too?
> > > 
> > > Not easily.
> > > 
> > > This behaviour can be turned off by not using the 'subdir-
> > > objects' automake
> > > option.
> > > 
> > > But then automake warns that option is disabled (since it's going
> > > to be the
> > > default in future).
> > 
> > So why not just move the mingw source files to utils/mingw, too?
> 
> There's probably some scope for doing that, but not in all cases, as 
> some files are built multiple times with different compilers and/or
> flags.
> 
> e.g. path.cc is built with a cygwin compiler and -DFSTAB as part of 
> mount, with a MinGW compiler as part of cygcheck, and with a MinGW 
> compiler and -DTESTSUITE as part of path-testsuite.

Then something like:

$ cat > winsup/utils/mingw/path.cc <<_EOF
#define MINGW // whatever is needed here...
#include "../path.cc"
_EOF

??

-- 
Yaakov


  reply	other threads:[~2020-12-02 18:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 13:37 Jon Turney
2020-11-30 10:25 ` Corinna Vinschen
2020-11-30 10:47   ` Corinna Vinschen
2020-11-30 17:02     ` Jon Turney
2020-12-01  9:18       ` Corinna Vinschen
2020-12-01 10:07         ` Corinna Vinschen
2020-12-02 16:08           ` Jon Turney
2020-12-02 17:00             ` Corinna Vinschen
2020-12-02 15:36         ` Jon Turney
2020-12-02 17:05           ` Corinna Vinschen
2020-12-02 18:03             ` Jon Turney
2020-12-02 18:33               ` Yaakov Selkowitz [this message]
2020-12-02 19:03                 ` Corinna Vinschen
2020-12-08 15:50                   ` Jon Turney
2020-11-30 17:01   ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42d8f1f139939b45fef85d00c3e368cf2500b603.camel@cygwin.com \
    --to=yselkowitz@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).