From: Jon Turney <jon.turney@dronecode.org.uk>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Use automake (v3)
Date: Mon, 30 Nov 2020 17:01:45 +0000 [thread overview]
Message-ID: <768836f9-dc70-bc1d-ef7e-23f053376100@dronecode.org.uk> (raw)
In-Reply-To: <20201130102524.GC303847@calimero.vinschen.de>
On 30/11/2020 10:25, Corinna Vinschen wrote:
> Hi Jon,
>
> On Nov 24 13:37, Jon Turney wrote:
>> For ease of reviewing, this patch doesn't contain changes to generated
>> files which would be made by running ./autogen.sh.
>>
>> v2:
>> * Include tzmap.h in BUILT_SOURCES
>> * Make per-file flags appear after user-supplied CXXFLAGS, so they can
>> override optimization level.
>> * Correct .o files used to define symbols exported by libm.a
>> * Drop gcrt0.o mistakenly incuded in libgmon.a
>> * Add missing line continuations in GMON_FILES value
>>
>> v3:
>> * use per-file flags for .c compilation
>> * override C{XX,}FLAGS, as they are set on the command line by top-level make
>
> Running autogen.sh shows a couple of warnings:
>
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> testsuite/cygrun/Makefile.am:16: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> automake: warning: redefinition of 'ps' ...
> /usr/share/automake-1.16/am/program.am: ... 'ps$(EXEEXT)' previously defined here
> utils/Makefile.am:15: while processing program 'ps'
> utils/mingw/Makefile.am:14: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
>
> Something to worry about?
Thanks for taking a look.
These warnings are expected at the moment.
I plan to clean up INCLUDES -> CPPFLAGS in a future patch
The redefinition of 'ps' is due to a conflict between a target built
into automake for postscript documentation and an executable we have
called 'ps'. I'm not sure how to address that.
prev parent reply other threads:[~2020-11-30 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 13:37 Jon Turney
2020-11-30 10:25 ` Corinna Vinschen
2020-11-30 10:47 ` Corinna Vinschen
2020-11-30 17:02 ` Jon Turney
2020-12-01 9:18 ` Corinna Vinschen
2020-12-01 10:07 ` Corinna Vinschen
2020-12-02 16:08 ` Jon Turney
2020-12-02 17:00 ` Corinna Vinschen
2020-12-02 15:36 ` Jon Turney
2020-12-02 17:05 ` Corinna Vinschen
2020-12-02 18:03 ` Jon Turney
2020-12-02 18:33 ` Yaakov Selkowitz
2020-12-02 19:03 ` Corinna Vinschen
2020-12-08 15:50 ` Jon Turney
2020-11-30 17:01 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768836f9-dc70-bc1d-ef7e-23f053376100@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).