Re: [PATCH] dumper: avoid linker problem when `libbfd` depends on `libsframe`

[Jon Turney <jon.turney@dronecode.org.uk>]

On 01/02/2023 17:33, Corinna Vinschen wrote:
> On Feb  1 15:08, Johannes Schindelin wrote:
>> A recent binutils version introduced `libsframe` and made it a
>> dependency of `libbfd`. This caused a linker problem in the MSYS2
>> project, and once Cygwin upgrades to that binutils version it would
>> cause the same problems there.
>>
>> Let's preemptively detect the presence of `libsframe` and if detected,
>> link to it in addition to `libbfd`.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> ---
>> Published-As: https://github.com/dscho/msys2-runtime/releases/tag/do-link-libsframe-if-available-v1
>> Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime do-link-libsframe-if-available-v1
>>
>>   winsup/configure.ac      | 5 +++++
>>   winsup/utils/Makefile.am | 4 ++++
>>   2 files changed, 9 insertions(+)
> 
> LGTM.  Jon, what do you think?

Well, the real solution here is for binutils to stop pretending that 
no-one links with libbfd and provide a .pc file for it, because we'll 
just be in the same situation the next time it grows another dependency.

Until that happens :), this seems fine.