From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] dumper: avoid linker problem when `libbfd` depends on `libsframe`
Date: Wed, 1 Feb 2023 20:03:29 +0100 [thread overview]
Message-ID: <Y9q3gY4rN9NbF/PZ@calimero.vinschen.de> (raw)
In-Reply-To: <6aa67503-30af-cf66-0b3a-1c4d9ba9c396@dronecode.org.uk>
On Feb 1 18:04, Jon Turney wrote:
> On 01/02/2023 17:33, Corinna Vinschen wrote:
> > On Feb 1 15:08, Johannes Schindelin wrote:
> > > A recent binutils version introduced `libsframe` and made it a
> > > dependency of `libbfd`. This caused a linker problem in the MSYS2
> > > project, and once Cygwin upgrades to that binutils version it would
> > > cause the same problems there.
> > >
> > > Let's preemptively detect the presence of `libsframe` and if detected,
> > > link to it in addition to `libbfd`.
> > >
> > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > > ---
> > > Published-As: https://github.com/dscho/msys2-runtime/releases/tag/do-link-libsframe-if-available-v1
> > > Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime do-link-libsframe-if-available-v1
> > >
> > > winsup/configure.ac | 5 +++++
> > > winsup/utils/Makefile.am | 4 ++++
> > > 2 files changed, 9 insertions(+)
> >
> > LGTM. Jon, what do you think?
>
> Well, the real solution here is for binutils to stop pretending that no-one
> links with libbfd and provide a .pc file for it, because we'll just be in
> the same situation the next time it grows another dependency.
>
> Until that happens :),
As in "never"? The binutils cygport package could provide it in
a kind of sneaky handcrafted way, couldn't it?
> this seems fine.
I pushed the patch.
Thanks,
Corinna
prev parent reply other threads:[~2023-02-01 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:08 Johannes Schindelin
2023-02-01 17:33 ` Corinna Vinschen
2023-02-01 18:04 ` Jon Turney
2023-02-01 19:03 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9q3gY4rN9NbF/PZ@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).