From: Jon Turney <jon.turney@dronecode.org.uk>
To: Mike Frysinger <vapier@gentoo.org>,
Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] winsup: enable maintainer mode support
Date: Tue, 1 Mar 2022 14:26:17 +0000 [thread overview]
Message-ID: <9a4b4c3c-f35f-920f-5937-bf119f63983e@dronecode.org.uk> (raw)
In-Reply-To: <20220301005439.23139-1-vapier@gentoo.org>
On 01/03/2022 00:54, Mike Frysinger wrote:
> We do this in newlib & libgloss, so enable in winsup too for consistency.
> ---
> winsup/configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/winsup/configure.ac b/winsup/configure.ac
> index b8d2100dbe90..6c6e1cb0893a 100644
> --- a/winsup/configure.ac
> +++ b/winsup/configure.ac
> @@ -13,6 +13,7 @@ AC_INIT([Cygwin],[0],[cygwin@cygwin.com],[cygwin],[https://cygwin.com])
> AC_CONFIG_AUX_DIR(..)
> AC_CANONICAL_TARGET
> AM_INIT_AUTOMAKE([dejagnu foreign no-define no-dist subdir-objects -Wall -Wno-portability -Wno-extra-portability])
> +AM_MAINTAINER_MODE
I'm not sure having maintainer-mode disabled by default for cygwin makes
a lot of sense.
We don't check in the autotools generated files, so for the handful of
people in the world who build cygwin from source from the git repo, they
should have autotools already installed and this just requires them to
know and remember to use '--enable-maintainer-mode'.
(There are no meaningful source archive releases of cygwin.)
I take the point about consistency, but I'm not sure what the arguments
are against using 'AM_MAINTAINER_MODE([enabled])' everywhere.
next prev parent reply other threads:[~2022-03-01 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 0:54 Mike Frysinger
2022-03-01 14:26 ` Jon Turney [this message]
2022-03-02 1:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4b4c3c-f35f-920f-5937-bf119f63983e@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).