[PATCH] winsup: enable maintainer mode support

[PATCH] winsup: enable maintainer mode support

[Mike Frysinger]

We do this in newlib & libgloss, so enable in winsup too for consistency.
---
 winsup/configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/configure.ac b/winsup/configure.ac
index b8d2100dbe90..6c6e1cb0893a 100644
--- a/winsup/configure.ac
+++ b/winsup/configure.ac
@@ -13,6 +13,7 @@ AC_INIT([Cygwin],[0],[cygwin@cygwin.com],[cygwin],[https://cygwin.com])
 AC_CONFIG_AUX_DIR(..)
 AC_CANONICAL_TARGET
 AM_INIT_AUTOMAKE([dejagnu foreign no-define no-dist subdir-objects -Wall -Wno-portability -Wno-extra-portability])
+AM_MAINTAINER_MODE
 AM_SILENT_RULES([yes])
 
 realdirpath() {
-- 
2.34.1

Re: [PATCH] winsup: enable maintainer mode support

[Jon Turney]

On 01/03/2022 00:54, Mike Frysinger wrote:
> We do this in newlib & libgloss, so enable in winsup too for consistency.
> ---
>   winsup/configure.ac | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/winsup/configure.ac b/winsup/configure.ac
> index b8d2100dbe90..6c6e1cb0893a 100644
> --- a/winsup/configure.ac
> +++ b/winsup/configure.ac
> @@ -13,6 +13,7 @@ AC_INIT([Cygwin],[0],[cygwin@cygwin.com],[cygwin],[https://cygwin.com])
>   AC_CONFIG_AUX_DIR(..)
>   AC_CANONICAL_TARGET
>   AM_INIT_AUTOMAKE([dejagnu foreign no-define no-dist subdir-objects -Wall -Wno-portability -Wno-extra-portability])
> +AM_MAINTAINER_MODE

I'm not sure having maintainer-mode disabled by default for cygwin makes 
a lot of sense.

We don't check in the autotools generated files, so for the handful of 
people in the world who build cygwin from source from the git repo, they 
should have autotools already installed and this just requires them to 
know and remember to use '--enable-maintainer-mode'.

(There are no meaningful source archive releases of cygwin.)

I take the point about consistency, but I'm not sure what the arguments 
are against using 'AM_MAINTAINER_MODE([enabled])' everywhere.

Re: [PATCH] winsup: enable maintainer mode support

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

On 01 Mar 2022 14:26, Jon Turney wrote:
> On 01/03/2022 00:54, Mike Frysinger wrote:
> > We do this in newlib & libgloss, so enable in winsup too for consistency.
> > ---
> >   winsup/configure.ac | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/winsup/configure.ac b/winsup/configure.ac
> > index b8d2100dbe90..6c6e1cb0893a 100644
> > --- a/winsup/configure.ac
> > +++ b/winsup/configure.ac
> > @@ -13,6 +13,7 @@ AC_INIT([Cygwin],[0],[cygwin@cygwin.com],[cygwin],[https://cygwin.com])
> >   AC_CONFIG_AUX_DIR(..)
> >   AC_CANONICAL_TARGET
> >   AM_INIT_AUTOMAKE([dejagnu foreign no-define no-dist subdir-objects -Wall -Wno-portability -Wno-extra-portability])
> > +AM_MAINTAINER_MODE
> 
> I'm not sure having maintainer-mode disabled by default for cygwin makes 
> a lot of sense.
> 
> We don't check in the autotools generated files, so for the handful of 
> people in the world who build cygwin from source from the git repo, they 
> should have autotools already installed and this just requires them to 
> know and remember to use '--enable-maintainer-mode'.
> 
> I take the point about consistency, but I'm not sure what the arguments 
> are against using 'AM_MAINTAINER_MODE([enabled])' everywhere.

tbh, it makes no diff to me -- merge or skip it, i'm fine either way.
just something i noticed while digging through things.

> (There are no meaningful source archive releases of cygwin.)

yeah, it's a shame because it makes building a cygwin toolchain a pita :p
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]