public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* Which git hash to supply on Fixes: line
@ 2023-11-13  6:01 Mark Geisert
  2023-11-13  9:40 ` Which git hash to supply on Fixes: line -- never mind Mark Geisert
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Geisert @ 2023-11-13  6:01 UTC (permalink / raw)
  To: cygwin-patches

Hi folks,
I want to submit a patch that fixes 'profiler'.  The Fixes: line of the 
patch commentary should reference the original addition of profiler to the 
Cygwin source tree.

Using the gitweb interface, the commit display of profiler.cc shows:
author	  Mark Geisert <mark@maxrnd.com>  2021-07-15 21:49:55 -0700
committer Jon Turney <jon.turney@...>     2021-07-19 13:28:37 +0100
commit	9bd6c0b2b1081ae72d8273038309887fb27f6126 (patch)
tree	360d7d3cc748683eb9e63729a7e52a62012730e4 /winsup/utils/profiler.cc
parent	Cygwin: cfsetspeed: allow speed to be a numerical baud rate (diff)

Do I use the last 13 nibbles of the "commit" hash or the "tree" hash?

First time I've seen both; on previous patches I've supplied a hash but 
I'm not sure which one of these they were because I was relying on some 
other method to find them.
Thanks,

..mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Which git hash to supply on Fixes: line -- never mind
  2023-11-13  6:01 Which git hash to supply on Fixes: line Mark Geisert
@ 2023-11-13  9:40 ` Mark Geisert
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Geisert @ 2023-11-13  9:40 UTC (permalink / raw)
  To: cygwin-patches

On Sun, 12 Nov 2023, Mark Geisert wrote:
> Hi folks,
> I want to submit a patch that fixes 'profiler'.  The Fixes: line of the patch 
> commentary should reference the original addition of profiler to the Cygwin 
> source tree.
>
> Using the gitweb interface, the commit display of profiler.cc shows:
> author	  Mark Geisert <mark@maxrnd.com>  2021-07-15 21:49:55 -0700
> committer Jon Turney <jon.turney@...>     2021-07-19 13:28:37 +0100
> commit	9bd6c0b2b1081ae72d8273038309887fb27f6126 (patch)
> tree	360d7d3cc748683eb9e63729a7e52a62012730e4 /winsup/utils/profiler.cc
> parent	Cygwin: cfsetspeed: allow speed to be a numerical baud rate (diff)
>
> Do I use the last 13 nibbles of the "commit" hash or the "tree" hash?

Never mind; I've figured it out.  It's the "commit" hash, which I 
determined by 'git log profiler.cc'.  Obvious in hindsight.
Cheers,

..mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-13  9:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13  6:01 Which git hash to supply on Fixes: line Mark Geisert
2023-11-13  9:40 ` Which git hash to supply on Fixes: line -- never mind Mark Geisert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).