Re: [PATCH] Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Nov 18 09:23, Johannes Schindelin wrote:
> Hi Corinna,
> 
> On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> 
> > However, two points:
> >
> > - I'm wondering if the patch (both of yours) doesn't actually just cover
> >   a problem in child_info_spawn::worker().  Different runpath values,
> >   depending on the app path being "cmd" or "cmd.exe"?  That sounds like
> >   worker() is doing weird stuff.  And it does in line 400ff.
> >
> >   So, if the else branch of this code is apparently working fine for
> >   "cmd" per Takashi's observation in
> >   https://cygwin.com/pipermail/cygwin-patches/2022q4/012032.html, how
> >   much sense is in the if branch handling "command.com" and "cmd.exe"
> >   specially?  Wouldn't a better patch get rid of this extra if and
> >   the null_app_name variable instead?
> 
> I never understood why the pcon code was allowed to be so Hydra-like as to
> sprawl into corners far, far beyond `winsup/cygwin/fhandler*`.
> 
> FWIW I would be in favor of getting rid of this special handling (unless
> it causes a regression).

I'm a bit surprised to read that, you should already have seen that.
I did so end of October:

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f33635ae6076
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=213b53ed3557


Corinna