From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: cygwin-patches@cygwin.com
Cc: Takashi Yano <takashi.yano@nifty.ne.jp>
Subject: Re: [PATCH] Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'
Date: Fri, 18 Nov 2022 09:23:01 +0100 (CET) [thread overview]
Message-ID: <s1268p66-18rs-9q3r-07oo-11o128pp06po@tzk.qr> (raw)
In-Reply-To: <Y1ZazH6objN99mSz@calimero.vinschen.de>
Hi Corinna,
On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> However, two points:
>
> - I'm wondering if the patch (both of yours) doesn't actually just cover
> a problem in child_info_spawn::worker(). Different runpath values,
> depending on the app path being "cmd" or "cmd.exe"? That sounds like
> worker() is doing weird stuff. And it does in line 400ff.
>
> So, if the else branch of this code is apparently working fine for
> "cmd" per Takashi's observation in
> https://cygwin.com/pipermail/cygwin-patches/2022q4/012032.html, how
> much sense is in the if branch handling "command.com" and "cmd.exe"
> specially? Wouldn't a better patch get rid of this extra if and
> the null_app_name variable instead?
I never understood why the pcon code was allowed to be so Hydra-like as to
sprawl into corners far, far beyond `winsup/cygwin/fhandler*`.
FWIW I would be in favor of getting rid of this special handling (unless
it causes a regression). Given the recent experience, I expect Takashi to
want to work on this without any interference from my side.
Ciao,
Dscho
next prev parent reply other threads:[~2022-11-18 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 5:34 Takashi Yano
2022-10-22 5:58 ` Johannes Schindelin
2022-10-22 6:12 ` Takashi Yano
2022-10-23 20:42 ` Johannes Schindelin
2022-10-24 9:28 ` Corinna Vinschen
2022-11-18 8:23 ` Johannes Schindelin [this message]
2022-11-19 21:38 ` Jeremy Drake
2022-11-21 11:47 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s1268p66-18rs-9q3r-07oo-11o128pp06po@tzk.qr \
--to=johannes.schindelin@gmx.de \
--cc=cygwin-patches@cygwin.com \
--cc=takashi.yano@nifty.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).