From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pty: Reflect tty settings to pseudo console mode.
Date: Fri, 19 Feb 2021 18:05:56 +0100 [thread overview]
Message-ID: <YC/v9DL2XE2Wkl1g@calimero.vinschen.de> (raw)
In-Reply-To: <20210218090539.1560-1-takashi.yano@nifty.ne.jp>
On Feb 18 18:05, Takashi Yano via Cygwin-patches wrote:
> - With this patch, tty setting such as echo, icanon, isig and onlcr
> are reflected to pseudo console mode.
> ---
> winsup/cygwin/fhandler_tty.cc | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 5afede859..e4c35ea41 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -3261,6 +3261,33 @@ skip_create:
> if (get_ttyp ()->previous_output_code_page)
> SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
>
> + do
> + {
> + termios &t = get_ttyp ()->ti;
> + DWORD mode;
> + /* Set input mode */
> + GetConsoleMode (hpConIn, &mode);
> + mode &= ~(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT);
> + if (t.c_lflag & ECHO)
> + mode |= ENABLE_ECHO_INPUT;
> + if (t.c_lflag & ICANON)
> + mode |= ENABLE_LINE_INPUT;
> + if (mode & ENABLE_ECHO_INPUT && !(mode & ENABLE_LINE_INPUT))
> + /* This is illegal, so turn off the echo here, and fake it
> + when we read the characters */
> + mode &= ~ENABLE_ECHO_INPUT;
> + if ((t.c_lflag & ISIG) && !(t.c_iflag & IGNBRK))
> + mode |= ENABLE_PROCESSED_INPUT;
> + SetConsoleMode (hpConIn, mode);
> + /* Set output mode */
> + GetConsoleMode (hpConOut, &mode);
> + mode &= ~DISABLE_NEWLINE_AUTO_RETURN;
> + if (!(t.c_oflag & OPOST) || !(t.c_oflag & ONLCR))
> + mode |= DISABLE_NEWLINE_AUTO_RETURN;
> + SetConsoleMode (hpConOut, mode);
> + }
> + while (false);
> +
> return true;
>
> cleanup_pcon_in:
> --
> 2.30.0
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2021-02-19 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:05 Takashi Yano
2021-02-19 17:05 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC/v9DL2XE2Wkl1g@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).