[PATCH] Cygwin: pty: Reflect tty settings to pseudo console mode.

[PATCH] Cygwin: pty: Reflect tty settings to pseudo console mode.

[Takashi Yano]

- With this patch, tty setting such as echo, icanon, isig and onlcr
  are reflected to pseudo console mode.
---
 winsup/cygwin/fhandler_tty.cc | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 5afede859..e4c35ea41 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -3261,6 +3261,33 @@ skip_create:
   if (get_ttyp ()->previous_output_code_page)
     SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
 
+  do
+    {
+      termios &t = get_ttyp ()->ti;
+      DWORD mode;
+      /* Set input mode */
+      GetConsoleMode (hpConIn, &mode);
+      mode &= ~(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT);
+      if (t.c_lflag & ECHO)
+	mode |= ENABLE_ECHO_INPUT;
+      if (t.c_lflag & ICANON)
+	mode |= ENABLE_LINE_INPUT;
+      if (mode & ENABLE_ECHO_INPUT && !(mode & ENABLE_LINE_INPUT))
+	/* This is illegal, so turn off the echo here, and fake it
+	   when we read the characters */
+	mode &= ~ENABLE_ECHO_INPUT;
+      if ((t.c_lflag & ISIG) && !(t.c_iflag & IGNBRK))
+	mode |= ENABLE_PROCESSED_INPUT;
+      SetConsoleMode (hpConIn, mode);
+      /* Set output mode */
+      GetConsoleMode (hpConOut, &mode);
+      mode &= ~DISABLE_NEWLINE_AUTO_RETURN;
+      if (!(t.c_oflag & OPOST) || !(t.c_oflag & ONLCR))
+	mode |= DISABLE_NEWLINE_AUTO_RETURN;
+      SetConsoleMode (hpConOut, mode);
+    }
+  while (false);
+
   return true;
 
 cleanup_pcon_in:
-- 
2.30.0

Re: [PATCH] Cygwin: pty: Reflect tty settings to pseudo console mode.

[Corinna Vinschen]

On Feb 18 18:05, Takashi Yano via Cygwin-patches wrote:
> - With this patch, tty setting such as echo, icanon, isig and onlcr
>   are reflected to pseudo console mode.
> ---
>  winsup/cygwin/fhandler_tty.cc | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 5afede859..e4c35ea41 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -3261,6 +3261,33 @@ skip_create:
>    if (get_ttyp ()->previous_output_code_page)
>      SetConsoleOutputCP (get_ttyp ()->previous_output_code_page);
>  
> +  do
> +    {
> +      termios &t = get_ttyp ()->ti;
> +      DWORD mode;
> +      /* Set input mode */
> +      GetConsoleMode (hpConIn, &mode);
> +      mode &= ~(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT);
> +      if (t.c_lflag & ECHO)
> +	mode |= ENABLE_ECHO_INPUT;
> +      if (t.c_lflag & ICANON)
> +	mode |= ENABLE_LINE_INPUT;
> +      if (mode & ENABLE_ECHO_INPUT && !(mode & ENABLE_LINE_INPUT))
> +	/* This is illegal, so turn off the echo here, and fake it
> +	   when we read the characters */
> +	mode &= ~ENABLE_ECHO_INPUT;
> +      if ((t.c_lflag & ISIG) && !(t.c_iflag & IGNBRK))
> +	mode |= ENABLE_PROCESSED_INPUT;
> +      SetConsoleMode (hpConIn, mode);
> +      /* Set output mode */
> +      GetConsoleMode (hpConOut, &mode);
> +      mode &= ~DISABLE_NEWLINE_AUTO_RETURN;
> +      if (!(t.c_oflag & OPOST) || !(t.c_oflag & ONLCR))
> +	mode |= DISABLE_NEWLINE_AUTO_RETURN;
> +      SetConsoleMode (hpConOut, mode);
> +    }
> +  while (false);
> +
>    return true;
>  
>  cleanup_pcon_in:
> -- 
> 2.30.0

Pushed.


Thanks,
Corinna