Re: [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe.

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Apr 20 05:51, Takashi Yano wrote:
> On Mon, 19 Apr 2021 16:19:09 +0200
> Corinna Vinschen wrote:
> > Hi Takashi,
> > 
> > On Apr 19 20:51, Takashi Yano wrote:
> > > - After the commit 919dea66, "rlwrap cmd" fails to start pseudo
> > >   console. This patch fixes the issue.
> > > ---
> > >  winsup/cygwin/fhandler_tty.cc | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > > index ba9f4117f..d44728795 100644
> > > --- a/winsup/cygwin/fhandler_tty.cc
> > > +++ b/winsup/cygwin/fhandler_tty.cc
> > > @@ -1170,6 +1170,8 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
> > >      }
> > >    if (isHybrid)
> > >      return;
> > > +  if (get_ttyp ()->pcon_start)
> > > +    return;
> > >    WaitForSingleObject (pcon_mutex, INFINITE);
> > >    if (!pcon_pid_self (get_ttyp ()->pcon_pid)
> > >        && pcon_pid_alive (get_ttyp ()->pcon_pid))
> > > -- 
> > > 2.31.1
> > 
> > this patch doesn't apply.  Does it depend on the race issue fixes?
> 
> Yes. This depends on the race issue patches.
> Please apply this patch after the race issue patches.
> 
> Thanks.

Pushed.


Thanks,
Corinna