* [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe.
@ 2021-04-19 11:51 Takashi Yano
2021-04-19 14:19 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Yano @ 2021-04-19 11:51 UTC (permalink / raw)
To: cygwin-patches
- After the commit 919dea66, "rlwrap cmd" fails to start pseudo
console. This patch fixes the issue.
---
winsup/cygwin/fhandler_tty.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index ba9f4117f..d44728795 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1170,6 +1170,8 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
}
if (isHybrid)
return;
+ if (get_ttyp ()->pcon_start)
+ return;
WaitForSingleObject (pcon_mutex, INFINITE);
if (!pcon_pid_self (get_ttyp ()->pcon_pid)
&& pcon_pid_alive (get_ttyp ()->pcon_pid))
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe.
2021-04-19 11:51 [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe Takashi Yano
@ 2021-04-19 14:19 ` Corinna Vinschen
2021-04-19 20:51 ` Takashi Yano
0 siblings, 1 reply; 4+ messages in thread
From: Corinna Vinschen @ 2021-04-19 14:19 UTC (permalink / raw)
To: cygwin-patches
Hi Takashi,
On Apr 19 20:51, Takashi Yano wrote:
> - After the commit 919dea66, "rlwrap cmd" fails to start pseudo
> console. This patch fixes the issue.
> ---
> winsup/cygwin/fhandler_tty.cc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index ba9f4117f..d44728795 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -1170,6 +1170,8 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
> }
> if (isHybrid)
> return;
> + if (get_ttyp ()->pcon_start)
> + return;
> WaitForSingleObject (pcon_mutex, INFINITE);
> if (!pcon_pid_self (get_ttyp ()->pcon_pid)
> && pcon_pid_alive (get_ttyp ()->pcon_pid))
> --
> 2.31.1
this patch doesn't apply. Does it depend on the race issue fixes?
Thanks,
Corinna
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe.
2021-04-19 14:19 ` Corinna Vinschen
@ 2021-04-19 20:51 ` Takashi Yano
2021-04-20 8:47 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Yano @ 2021-04-19 20:51 UTC (permalink / raw)
To: cygwin-patches
On Mon, 19 Apr 2021 16:19:09 +0200
Corinna Vinschen wrote:
> Hi Takashi,
>
> On Apr 19 20:51, Takashi Yano wrote:
> > - After the commit 919dea66, "rlwrap cmd" fails to start pseudo
> > console. This patch fixes the issue.
> > ---
> > winsup/cygwin/fhandler_tty.cc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > index ba9f4117f..d44728795 100644
> > --- a/winsup/cygwin/fhandler_tty.cc
> > +++ b/winsup/cygwin/fhandler_tty.cc
> > @@ -1170,6 +1170,8 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
> > }
> > if (isHybrid)
> > return;
> > + if (get_ttyp ()->pcon_start)
> > + return;
> > WaitForSingleObject (pcon_mutex, INFINITE);
> > if (!pcon_pid_self (get_ttyp ()->pcon_pid)
> > && pcon_pid_alive (get_ttyp ()->pcon_pid))
> > --
> > 2.31.1
>
> this patch doesn't apply. Does it depend on the race issue fixes?
Yes. This depends on the race issue patches.
Please apply this patch after the race issue patches.
Thanks.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe.
2021-04-19 20:51 ` Takashi Yano
@ 2021-04-20 8:47 ` Corinna Vinschen
0 siblings, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2021-04-20 8:47 UTC (permalink / raw)
To: cygwin-patches
On Apr 20 05:51, Takashi Yano wrote:
> On Mon, 19 Apr 2021 16:19:09 +0200
> Corinna Vinschen wrote:
> > Hi Takashi,
> >
> > On Apr 19 20:51, Takashi Yano wrote:
> > > - After the commit 919dea66, "rlwrap cmd" fails to start pseudo
> > > console. This patch fixes the issue.
> > > ---
> > > winsup/cygwin/fhandler_tty.cc | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > > index ba9f4117f..d44728795 100644
> > > --- a/winsup/cygwin/fhandler_tty.cc
> > > +++ b/winsup/cygwin/fhandler_tty.cc
> > > @@ -1170,6 +1170,8 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
> > > }
> > > if (isHybrid)
> > > return;
> > > + if (get_ttyp ()->pcon_start)
> > > + return;
> > > WaitForSingleObject (pcon_mutex, INFINITE);
> > > if (!pcon_pid_self (get_ttyp ()->pcon_pid)
> > > && pcon_pid_alive (get_ttyp ()->pcon_pid))
> > > --
> > > 2.31.1
> >
> > this patch doesn't apply. Does it depend on the race issue fixes?
>
> Yes. This depends on the race issue patches.
> Please apply this patch after the race issue patches.
>
> Thanks.
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-20 8:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 11:51 [PATCH] Cygwin: pty: Make rlwrap work with cmd.exe Takashi Yano
2021-04-19 14:19 ` Corinna Vinschen
2021-04-19 20:51 ` Takashi Yano
2021-04-20 8:47 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).