From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: utils: chattr: Improve option parsing.
Date: Thu, 20 May 2021 22:40:24 +0200 [thread overview]
Message-ID: <YKbJOEBmYEkVsEk3@calimero.vinschen.de> (raw)
In-Reply-To: <e78257d8-bd2a-3ea0-0cea-48114ec017a0@t-online.de>
On May 20 12:01, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Hi Christian,
> >
> > On May 19 17:46, Christian Franke wrote:
> > > ...
> > > $ egrep 'ACL|--r' chattr.c
> > > "Get POSIX ACL information\n"
> > > " -R, --recursive recursively list attributes of directories and
> > > their \n"
> > Oops. Please patch while you're at it...
> > ...
> > > From 865a5a50501f3fd0cf5ed28500d3e6e45a6456de Mon Sep 17 00:00:00 2001
> > > From: Christian Franke<...>
> > > Date: Wed, 19 May 2021 16:24:47 +0200
> > > Subject: [PATCH] Cygwin: utils: chattr: Improve option parsing.
> > >
> > > Interpret '-h' as '--help' only if last argument.
> > Who was the idiot using -h for help *and* the hidden flag? *blush*
> >
> > I'd vote for --help to be changed to -H for the single character
> > option. The help output is very unlikely to be used in scripts,
> > so that shouldn't be a backward compat problem.
>
> New patch attached.
>
> Note that there is now the possibly unexpected (& hidden) behavior that
> 'chattr -h' without file argument clears the hidden attribute of cwd.
>
> Regards,
> Christian
>
> From b838125f797c123d4a6d2f0ef30cccee8face50c Mon Sep 17 00:00:00 2001
> From: Christian Franke <christian.franke@t-online.de>
> Date: Thu, 20 May 2021 11:05:29 +0200
> Subject: [PATCH] Cygwin: utils: chattr: Improve option parsing, fix some
> messages.
>
> Allow multiple characters also in first '-mode' argument.
> Use '-H' instead of '-h' for '--help' to fix ambiguity with
> hidden attribute. Fix help and usage texts and documentation.
>
> Signed-off-by: Christian Franke <christian.franke@t-online.de>
> ---
> winsup/doc/utils.xml | 10 +++++-----
> winsup/utils/chattr.c | 32 ++++++++++++++------------------
> 2 files changed, 19 insertions(+), 23 deletions(-)
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2021-05-20 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 15:46 Christian Franke
2021-05-19 17:47 ` Corinna Vinschen
2021-05-20 10:01 ` Christian Franke
2021-05-20 17:57 ` Corinna Vinschen
2021-05-20 19:48 ` Christian Franke
2021-05-20 20:19 ` Corinna Vinschen
2021-05-20 20:40 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKbJOEBmYEkVsEk3@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).