* [PATCH] Cygwin: console: Fix garbled input for non-ASCII chars.
@ 2021-06-23 8:42 Takashi Yano
2021-07-06 14:00 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2021-06-23 8:42 UTC (permalink / raw)
To: cygwin-patches
- After the commit ff4440fc, non-ASCII input may sometimes be garbled.
This patch fixes the issue.
Addresses: https://cygwin.com/pipermail/cygwin/2021-June/248775.html
---
winsup/cygwin/fhandler_console.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index b3eae6a5a..76689c674 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -213,7 +213,7 @@ fhandler_console::cons_master_thread (handle_set_t *p, tty *ttyp)
switch (cygwait (p->input_handle, (DWORD) 0))
{
case WAIT_OBJECT_0:
- ReadConsoleInputA (p->input_handle,
+ ReadConsoleInputW (p->input_handle,
input_rec, INREC_SIZE, &total_read);
break;
case WAIT_TIMEOUT:
@@ -326,7 +326,7 @@ fhandler_console::cons_master_thread (handle_set_t *p, tty *ttyp)
}
if (total_read)
/* Write back input records other than interrupt. */
- WriteConsoleInput (p->input_handle, input_rec, total_read, &n);
+ WriteConsoleInputW (p->input_handle, input_rec, total_read, &n);
skip_writeback:
ReleaseMutex (p->input_mutex);
cygwait (40);
--
2.32.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: console: Fix garbled input for non-ASCII chars.
2021-06-23 8:42 [PATCH] Cygwin: console: Fix garbled input for non-ASCII chars Takashi Yano
@ 2021-07-06 14:00 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2021-07-06 14:00 UTC (permalink / raw)
To: cygwin-patches
On Jun 23 17:42, Takashi Yano wrote:
> - After the commit ff4440fc, non-ASCII input may sometimes be garbled.
> This patch fixes the issue.
>
> Addresses: https://cygwin.com/pipermail/cygwin/2021-June/248775.html
> ---
> winsup/cygwin/fhandler_console.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-06 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 8:42 [PATCH] Cygwin: console: Fix garbled input for non-ASCII chars Takashi Yano
2021-07-06 14:00 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).