From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pipe: Fix raw_write() for non-cygwin pipe with size zero.
Date: Thu, 11 Nov 2021 10:10:37 +0100 [thread overview]
Message-ID: <YYzeDTmhDjm1nCsD@calimero.vinschen.de> (raw)
In-Reply-To: <20211111081923.802-1-takashi.yano@nifty.ne.jp>
On Nov 11 17:19, Takashi Yano wrote:
> - Currently, raw_write() fails to handle size zero pipe which may
> be created by non-cygwin apps (e.g. Windows native ninja). This
> patch fixes the issue.
>
> Addresses:
> https://cygwin.com/pipermail/cygwin/2021-November/249844.html
> ---
> winsup/cygwin/fhandler_pipe.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
> index 13731437e..9392a28c1 100644
> --- a/winsup/cygwin/fhandler_pipe.cc
> +++ b/winsup/cygwin/fhandler_pipe.cc
> @@ -449,7 +449,7 @@ fhandler_pipe_fifo::raw_write (const void *ptr, size_t len)
> return -1;
> }
>
> - if (len <= pipe_buf_size)
> + if (len <= pipe_buf_size || pipe_buf_size == 0)
> chunk = len;
> else if (is_nonblocking ())
> chunk = len = pipe_buf_size;
> --
> 2.33.0
ACK. Please push.
Thanks,
Corinna
prev parent reply other threads:[~2021-11-11 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 8:19 Takashi Yano
2021-11-11 9:10 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYzeDTmhDjm1nCsD@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).