From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency
Date: Mon, 17 Jan 2022 11:44:25 +0100 [thread overview]
Message-ID: <YeVIiWS/NGobR/gr@calimero.vinschen.de> (raw)
In-Reply-To: <YeVHVqx2kKnjt7DV@calimero.vinschen.de>
On Jan 17 11:39, Corinna Vinschen wrote:
> Hi Anton,
>
> I pushed the first two patches. However...
>
> On Jan 14 17:10, Anton Lavrentiev via Cygwin-patches wrote:
> > ---
> > winsup/cygwin/libc/minires.c | 28 ++++++++++++++++++----------
> > 1 file changed, 18 insertions(+), 10 deletions(-)
>
> ...would you mind to shorten your commit caption (aka subject), at least
> to less than 80 chars, and outline your patch in the remainder of the
> commit message, please?
>
> In fact, a short subject and a bit of explaining text in the commit
> message is preferrable in general. See the DISCUSSION section in the
> git-commit(1) man page.
Oh, and, while we're at it, please add a prefix to the subjects of your
remaining patches, i .e.
Cygwin: resolver: blah
I forget that for the first two patches, but we should do this a bit
more thorough.
Other than that, the remaining patches look good, except, adding a short
description what patch 7 does to the commit message would be great for
later readers of the git log.
Thanks,
Corinna
next prev parent reply other threads:[~2022-01-17 10:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 22:10 Cygwin: A few fixes for local resolver Anton Lavrentiev
2022-01-14 22:10 ` [PATCH 1/7] Fix format specifier for wide-char string Anton Lavrentiev
2022-01-14 22:10 ` [PATCH 2/7] Use matching format for NTSTATUS Anton Lavrentiev
2022-01-15 4:38 ` Brian Inglis
2022-01-15 19:04 ` [EXTERNAL] " Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2022-01-15 22:38 ` Brian Inglis
2022-01-16 0:20 ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2022-01-14 22:10 ` [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency Anton Lavrentiev
2022-01-17 10:39 ` Corinna Vinschen
2022-01-17 10:44 ` Corinna Vinschen [this message]
2022-01-14 22:10 ` [PATCH 4/7] Process options forward (not backwards) Anton Lavrentiev
2022-01-14 22:10 ` [PATCH 5/7] Format consitency for Windows errors Anton Lavrentiev
2022-01-14 22:10 ` [PATCH 6/7] Message consistency Anton Lavrentiev
2022-01-14 22:10 ` [PATCH 7/7] Added processing of AAAA records Anton Lavrentiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeVIiWS/NGobR/gr@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).