* [PATCH] Cygwin: Fix __cpuset_zero_s prototype
@ 2023-09-08 5:36 Mark Geisert
2023-09-08 14:08 ` Corinna Vinschen
2023-09-09 21:29 ` Corinna Vinschen
0 siblings, 2 replies; 7+ messages in thread
From: Mark Geisert @ 2023-09-08 5:36 UTC (permalink / raw)
To: cygwin-patches; +Cc: Mark Geisert, Marco Mason
Add a missing "void" to the prototype for __cpuset_zero_s().
Reported-by: Marco Mason <marco.mason@gmail.com>
Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
Signed-off-by: Mark Geisert <mark@maxrnd.com>
Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
---
winsup/cygwin/include/sys/cpuset.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/include/sys/cpuset.h b/winsup/cygwin/include/sys/cpuset.h
index a5a8fa81e..3d0874880 100644
--- a/winsup/cygwin/include/sys/cpuset.h
+++ b/winsup/cygwin/include/sys/cpuset.h
@@ -48,7 +48,7 @@ void __cpuset_free (cpu_set_t *);
/* These _S macros operate on dynamically-sized cpu sets of size 'siz' bytes */
#define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
-static __inline
+static __inline void
__cpuset_zero_s (__size_t siz, cpu_set_t *set)
{
#if __GNUC_PREREQ (2, 91)
--
2.39.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-08 5:36 [PATCH] Cygwin: Fix __cpuset_zero_s prototype Mark Geisert
@ 2023-09-08 14:08 ` Corinna Vinschen
2023-09-09 6:51 ` Mark Geisert
2023-09-09 21:29 ` Corinna Vinschen
1 sibling, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2023-09-08 14:08 UTC (permalink / raw)
To: cygwin-patches
On Sep 7 22:36, Mark Geisert wrote:
> Add a missing "void" to the prototype for __cpuset_zero_s().
>
> Reported-by: Marco Mason <marco.mason@gmail.com>
> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
> Signed-off-by: Mark Geisert <mark@maxrnd.com>
> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
Thanks, can you also add an entry to the 3.4.10 release file
(which doesn't exist yet), please?
Corinna
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-08 14:08 ` Corinna Vinschen
@ 2023-09-09 6:51 ` Mark Geisert
2023-09-09 6:57 ` Mark Geisert
0 siblings, 1 reply; 7+ messages in thread
From: Mark Geisert @ 2023-09-09 6:51 UTC (permalink / raw)
To: cygwin-patches
Corinna Vinschen wrote:
> On Sep 7 22:36, Mark Geisert wrote:
>> Add a missing "void" to the prototype for __cpuset_zero_s().
>>
>> Reported-by: Marco Mason <marco.mason@gmail.com>
>> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
>> Signed-off-by: Mark Geisert <mark@maxrnd.com>
>> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
>
> Thanks, can you also add an entry to the 3.4.10 release file
> (which doesn't exist yet), please?
Done. Here's a link:
https://cygwin.com/pipermail/cygwin/2023-September/254423.html
Cheers,
..mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-09 6:51 ` Mark Geisert
@ 2023-09-09 6:57 ` Mark Geisert
0 siblings, 0 replies; 7+ messages in thread
From: Mark Geisert @ 2023-09-09 6:57 UTC (permalink / raw)
To: cygwin-patches
Mark Geisert wrote, and then wrote again:
> Corinna Vinschen wrote:
>> On Sep 7 22:36, Mark Geisert wrote:
>>> Add a missing "void" to the prototype for __cpuset_zero_s().
>>>
>>> Reported-by: Marco Mason <marco.mason@gmail.com>
>>> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
>>> Signed-off-by: Mark Geisert <mark@maxrnd.com>
>>> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
>>
>> Thanks, can you also add an entry to the 3.4.10 release file
>> (which doesn't exist yet), please?
>
> Done. Here's a link:
> https://cygwin.com/pipermail/cygwin/2023-September/254423.html
D'oh again! Here's the correct link. Sorry for the continuing noise.
https://cygwin.com/pipermail/cygwin-patches/2023q3/012481.html
..mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-08 5:36 [PATCH] Cygwin: Fix __cpuset_zero_s prototype Mark Geisert
2023-09-08 14:08 ` Corinna Vinschen
@ 2023-09-09 21:29 ` Corinna Vinschen
2023-09-09 23:37 ` Takashi Yano
1 sibling, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2023-09-09 21:29 UTC (permalink / raw)
To: cygwin-patches
On Sep 7 22:36, Mark Geisert wrote:
> Add a missing "void" to the prototype for __cpuset_zero_s().
>
> Reported-by: Marco Mason <marco.mason@gmail.com>
> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
> Signed-off-by: Mark Geisert <mark@maxrnd.com>
> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
>
> ---
> winsup/cygwin/include/sys/cpuset.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Pushed, including doc fix.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-09 21:29 ` Corinna Vinschen
@ 2023-09-09 23:37 ` Takashi Yano
2023-09-10 13:38 ` Jon Turney
0 siblings, 1 reply; 7+ messages in thread
From: Takashi Yano @ 2023-09-09 23:37 UTC (permalink / raw)
To: cygwin-patches
Hi Corinna,
On Sat, 9 Sep 2023 23:29:22 +0200
Corinna Vinschen wrote:
> On Sep 7 22:36, Mark Geisert wrote:
> > Add a missing "void" to the prototype for __cpuset_zero_s().
> >
> > Reported-by: Marco Mason <marco.mason@gmail.com>
> > Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
> > Signed-off-by: Mark Geisert <mark@maxrnd.com>
> > Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
> >
> > ---
> > winsup/cygwin/include/sys/cpuset.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Pushed, including doc fix.
These patch shoud be applied also to cygwin-3_4-branch, but didn't.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Cygwin: Fix __cpuset_zero_s prototype
2023-09-09 23:37 ` Takashi Yano
@ 2023-09-10 13:38 ` Jon Turney
0 siblings, 0 replies; 7+ messages in thread
From: Jon Turney @ 2023-09-10 13:38 UTC (permalink / raw)
To: Cygwin Patches
On 10/09/2023 00:37, Takashi Yano wrote:
> Hi Corinna,
>
> On Sat, 9 Sep 2023 23:29:22 +0200
> Corinna Vinschen wrote:
>> On Sep 7 22:36, Mark Geisert wrote:
>>> Add a missing "void" to the prototype for __cpuset_zero_s().
>>>
>>> Reported-by: Marco Mason <marco.mason@gmail.com>
>>> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
>>> Signed-off-by: Mark Geisert <mark@maxrnd.com>
>>> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-specific external functions)
>>>
>>> ---
>>> winsup/cygwin/include/sys/cpuset.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Pushed, including doc fix.
>
> These patch shoud be applied also to cygwin-3_4-branch, but didn't.
>
Good point. I went ahead and did that.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-09-10 13:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-08 5:36 [PATCH] Cygwin: Fix __cpuset_zero_s prototype Mark Geisert
2023-09-08 14:08 ` Corinna Vinschen
2023-09-09 6:51 ` Mark Geisert
2023-09-09 6:57 ` Mark Geisert
2023-09-09 21:29 ` Corinna Vinschen
2023-09-09 23:37 ` Takashi Yano
2023-09-10 13:38 ` Jon Turney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).